Page MenuHomePhabricator

[MLIR] NFC: simplify PresburgerSet::isEqual
ClosedPublic

Authored by arjunp on Jan 18 2021, 8:44 AM.

Diff Detail

Event Timeline

arjunp created this revision.Jan 18 2021, 8:44 AM
arjunp requested review of this revision.Jan 18 2021, 8:44 AM

It's unclear to me, does something like this need pre-commit review?

ftynse accepted this revision.Jan 18 2021, 8:50 AM

We generally use code review for everything except build unbreaks, reverts and minor syntactic changes such as typos.

This revision is now accepted and ready to land.Jan 18 2021, 8:50 AM
This revision was automatically updated to reflect the committed changes.

We generally use code review for everything except build unbreaks, reverts and minor syntactic changes such as typos.

I have a more liberal view here, I've been performing refactoring and other kind of NFC or minor change without pre-commit reviews. In general many people (including me) are just reviewing a few things post-commit.

We generally use code review for everything except build unbreaks, reverts and minor syntactic changes such as typos.

I have a more liberal view here, I've been performing refactoring and other kind of NFC or minor change without pre-commit reviews. In general many people (including me) are just reviewing a few things post-commit.

I should add this is also very contextual: I wouldn't refactor linalg without asking ntv@ or the LLVM dialect without asking @zinenko, but for example such minor things in PresburgerSet made by the main authors/contributors of this component looks fine to me to land directly if they are confident enough.