This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Add support for mapping names in mapper API
ClosedPublic

Authored by jhuber6 on Jan 15 2021, 10:16 AM.

Details

Summary

The custom mapper API did not previously support the mapping names added previously. This means they were not present if a user requested debugging information while using the mapper functions. This adds basic support for passing the mapped names to the runtime library.

Diff Detail

Event Timeline

jhuber6 created this revision.Jan 15 2021, 10:16 AM
jhuber6 requested review of this revision.Jan 15 2021, 10:16 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJan 15 2021, 10:16 AM
This revision is now accepted and ready to land.Jan 15 2021, 10:22 AM
jhuber6 updated this revision to Diff 317038.Jan 15 2021, 11:45 AM

Fixed test

jhuber6 updated this revision to Diff 317994.Jan 20 2021, 1:40 PM

Changing the handling of OMP_TGT_MAPTYPE_PTR_AND_OBJ so it will not pass the same name for the base object. This doesn't pass in the correct name, simply makes it show up as unknown if queried.

jhuber6 updated this revision to Diff 318061.Jan 20 2021, 4:29 PM

Adding a test case for the mapper names.

This revision was landed with ongoing or failed builds.Jan 21 2021, 6:27 AM
This revision was automatically updated to reflect the committed changes.
MaskRay added a subscriber: MaskRay.EditedJan 26 2021, 9:12 AM

In your commit the message has just Reviewers:. The Reviewers: list does not necessarily mean all the people on the list have acknowledged the patch so Reviewers: is mostly useless. Many people agree that both Reviewed by: & Differential Revision: should be present.

arc amend can fetch the Phabricator summary and amend the local description.

You can install llvm/.git/hooks/pre-push to prevent accidental Summary:, Reviewers:, Subscribers: and Tags:.