Page MenuHomePhabricator

[mlir] Update doc to omit the usage of LLVMIntegerType
ClosedPublic

Authored by Lewuathe on Wed, Jan 13, 9:50 PM.

Details

Summary

Since the LLVMIntegerType was replaced with build-in integer type, the usage in the tutorial should be also updated accordingly.
We need to update chapter 6 for Toy tutorial specifically.

See: https://reviews.llvm.org/D94178

Diff Detail

Event Timeline

Lewuathe created this revision.Wed, Jan 13, 9:50 PM
Lewuathe requested review of this revision.Wed, Jan 13, 9:50 PM
Lewuathe retitled this revision from Since the LLVMIntegerType was replaced with build-in integer type, the usage in the tutorial should be also updated accordingly. to [mlir] Update doc to omit the usage of LLVMIntegerType.
Lewuathe edited the summary of this revision. (Show Details)
Lewuathe edited the summary of this revision. (Show Details)
rriddle accepted this revision.Wed, Jan 13, 10:03 PM
This revision is now accepted and ready to land.Wed, Jan 13, 10:03 PM

@rriddle Thank you! Since I do not have write access, could you land this change in the repo on behalf of me?

This revision was automatically updated to reflect the committed changes.
ftynse added a subscriber: ftynse.Thu, Jan 14, 12:31 AM

Please consider avoiding "advanced" markdown features in the commit messages, a lot of people look at them in the terminal and it may be hard to parse

[url | long description that
spans several lines]

mentally. Small things like underscores and asterisks for highlighting are fine IMO.