This is an archive of the discontinued LLVM Phabricator instance.

Differential D94455

Add sample-profile-suffix-elision-policy attribute with -funique-internal-linkage-names.
ClosedPublic

Authored by hoy on Jan 11 2021, 2:45 PM.

Details

Reviewers
dblaikie
tmsriram
Commits
rG175288a1afef: Add sample-profile-suffix-elision-policy attribute with -funique-internal…
Summary

Adding sample-profile-suffix-elision-policy attribute to functions whose linkage names are uniquefied so that their unique name suffix won't be trimmed when applying AutoFDO profiles.

Diff Detail

Event Timeline

hoy created this revision.Jan 11 2021, 2:45 PM
Herald added subscribers: wenlei, hiraditya. · View Herald TranscriptJan 11 2021, 2:45 PM
hoy requested review of this revision.Jan 11 2021, 2:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2021, 2:45 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
hoy added a parent revision: D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm..Jan 11 2021, 2:46 PM
hoy edited the summary of this revision. (Show Details)
hoy added reviewers: dblaikie, tmsriram.
Harbormaster completed remote builds in B84766: Diff 315942.Jan 11 2021, 3:38 PM
dblaikie accepted this revision.Jan 12 2021, 12:07 PM

Sounds OK

This revision is now accepted and ready to land.Jan 12 2021, 12:07 PM
Closed by commit rG175288a1afef: Add sample-profile-suffix-elision-policy attribute with -funique-internal… (authored by hoy). · Explain WhyJan 12 2021, 3:16 PM
This revision was automatically updated to reflect the committed changes.
hoy added a commit: rG175288a1afef: Add sample-profile-suffix-elision-policy attribute with -funique-internal….

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
1 line
test/
Transforms/
UniqueInternalLinkageNames/
3 lines

Diff 316253

llvm/lib/Transforms/Utils/UniqueInternalLinkageNames.cpp

Show All 37 Linesstatic bool uniqueifyInternalLinkageNames(Module &M) {
std::string ModuleNameHash = (Twine(".__uniq.") + Twine(IntHash.toString(10, false))).str(); std::string ModuleNameHash = (Twine(".__uniq.") + Twine(IntHash.toString(10, false))).str();
bool Changed = false; bool Changed = false;
MDBuilder MDB(M.getContext()); MDBuilder MDB(M.getContext());
// Append the module hash to all internal linkage functions. // Append the module hash to all internal linkage functions.
for (auto &F : M) { for (auto &F : M) {
if (F.hasInternalLinkage()) { if (F.hasInternalLinkage()) {
F.setName(F.getName() + ModuleNameHash); F.setName(F.getName() + ModuleNameHash);
F.addFnAttr("sample-profile-suffix-elision-policy", "selected");
// Replace linkage names in the debug metadata. // Replace linkage names in the debug metadata.
if (DISubprogram *SP = F.getSubprogram()) { if (DISubprogram *SP = F.getSubprogram()) {
if (SP->getRawLinkageName()) { if (SP->getRawLinkageName()) {
auto *Name = MDB.createString(F.getName()); auto *Name = MDB.createString(F.getName());
SP->replaceRawLinkageName(Name); SP->replaceRawLinkageName(Name);
if (DISubprogram *SPDecl = SP->getDeclaration()) { if (DISubprogram *SPDecl = SP->getDeclaration()) {
if (SPDecl->getRawLinkageName()) if (SPDecl->getRawLinkageName())
SPDecl->replaceRawLinkageName(Name); SPDecl->replaceRawLinkageName(Name);
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines

llvm/test/Transforms/UniqueInternalLinkageNames/unique-internal-linkage-names.ll

Show All 36 Lines
!19 = distinct !DISubprogram(name: "go", scope: !1, file: !1, line: 5, type: !16, scopeLine: 5, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !0, declaration: !18, retainedNodes: !2) !19 = distinct !DISubprogram(name: "go", scope: !1, file: !1, line: 5, type: !16, scopeLine: 5, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !0, declaration: !18, retainedNodes: !2)
; O0: Running pass: UniqueInternalLinkageNamesPass ; O0: Running pass: UniqueInternalLinkageNamesPass
;; Check UniqueInternalLinkageNamesPass is scheduled before SampleProfileProbePass. ;; Check UniqueInternalLinkageNamesPass is scheduled before SampleProfileProbePass.
; O2: Running pass: UniqueInternalLinkageNamesPass ; O2: Running pass: UniqueInternalLinkageNamesPass
; O2: Running pass: SampleProfileProbePass ; O2: Running pass: SampleProfileProbePass
; UNIQUE: define internal i32 @foo.__uniq.{{[0-9]+}}() ; UNIQUE: define internal i32 @foo.__uniq.{{[0-9]+}}() [[ATTR:#[0-9]+]]
; UNIQUE: ret {{.*}} @foo.__uniq.{{[0-9]+}} {{.*}} ; UNIQUE: ret {{.*}} @foo.__uniq.{{[0-9]+}} {{.*}}
; UNIQUE: attributes [[ATTR]] = {{{.*}} "sample-profile-suffix-elision-policy"="selected" {{.*}}}
; DBG: distinct !DISubprogram(name: "foo", linkageName: "foo.__uniq.{{[0-9]+}}", scope: ![[#]] ; DBG: distinct !DISubprogram(name: "foo", linkageName: "foo.__uniq.{{[0-9]+}}", scope: ![[#]]
; DBG: !DISubprogram(name: "foo", linkageName: "foo.__uniq.{{[0-9]+}}", scope: ![[#]] ; DBG: !DISubprogram(name: "foo", linkageName: "foo.__uniq.{{[0-9]+}}", scope: ![[#]]
; DBG: distinct !DISubprogram(name: "go", scope: ![[#]] ; DBG: distinct !DISubprogram(name: "go", scope: ![[#]]