Page MenuHomePhabricator

tmsriram (Sriraman Tallam)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2016, 10:26 AM (207 w, 6 d)

Recent Activity

Today

tmsriram updated the summary of D68049: Propeller: Clang options for basic block sections .
Tue, Mar 31, 5:06 PM · Restricted Project

Yesterday

tmsriram added inline comments to D73307: Unique Names for Functions with Internal Linkage.
Mon, Mar 30, 6:35 PM
tmsriram abandoned D73310: Allow Module name to be used to generate a unique Module ID.

D73307 directly computes the hash so this is no longer necessary.

Mon, Mar 30, 9:44 AM · Restricted Project

Fri, Mar 27

tmsriram added a comment to D76954: LLVM support for BB-cluster sections.

Took one pass over the code.

  • This needs more tests like with exception blocks kept in separate clusters (check if they are grouped)
Fri, Mar 27, 10:00 PM · Restricted Project
tmsriram updated the diff for D68049: Propeller: Clang options for basic block sections .

Clang options for Basic Block Sections enabled in D68063 and D73674

Fri, Mar 27, 6:45 PM · Restricted Project

Wed, Mar 25

tmsriram added a comment to D73307: Unique Names for Functions with Internal Linkage.
In D73307#1932131, @rnk wrote:

At a higher level, should this just be an IR pass that clang adds into the pipeline when the flag is set? It should be safe to rename internal functions and give private functions internal linkage. It would be less invasive to clang and have better separation of concerns. As written, this is based on the source filename on the module, which is accessible from IR. The only reason I can think of against this is that the debug info might refer to the function linkage name, but maybe that is calculated later during codegen.

I second this suggestion. clang/lib/CodeGen/BackendUtil.cpp EmitAssemblyHelper::EmitAssemblyWithNewPassManager ModulePassManager may be a more appropriate place for this feature. There are examples from both sides:

Wed, Mar 25, 10:11 PM
tmsriram updated the summary of D68065: Propeller: LLD Support for Basic Block Sections.
Wed, Mar 25, 9:07 PM · Restricted Project, lld
tmsriram updated subscribers of D68065: Propeller: LLD Support for Basic Block Sections.

Hi Sriraman,

Sounds like there is strong support for your patch, so let’s move forward on it.

I do have a few more code review items I’d like addressed if we can before we commit.
There are several nits about excess parentheses which do not fit with the rest of lld code.
Please scan the full patch and delete them. Rebase and upload a new diff so that I can patch my local repository with arc patch D68065.
It does not apply so it isn’t convenient for me to review the tests now.

In addition, we probably should move test/ELF/bb-sections-* tests to test/ELF/propeller/

Wed, Mar 25, 8:35 PM · Restricted Project, lld
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Address recent reviewer comments.

Wed, Mar 25, 8:35 PM · Restricted Project, lld
tmsriram updated the diff for D73307: Unique Names for Functions with Internal Linkage.

Changes to description of flag, remove redundant check.

Wed, Mar 25, 3:43 PM

Tue, Mar 24

tmsriram updated subscribers of D68065: Propeller: LLD Support for Basic Block Sections.

I am very glad to see that we have made progress by landing D68063 (llvm/CodeGen/CommandFlags.inc) and D73674 (llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp). Basic block sections is agreed to be useful even outside Properller.

There are several optimizations goals:

  • Alignment inserting
  • Automatic cache prefetching
  • Large code model addressing can lower performance quite a bit. A post-link scheme can relax large code model addressting to small code model addressing.
  • ...
Tue, Mar 24, 1:35 AM · Restricted Project, lld

Mon, Mar 23

tmsriram added a comment to D73307: Unique Names for Functions with Internal Linkage.

Ping.

Mon, Mar 23, 10:49 PM
tmsriram added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

I am very glad to see that we have made progress by landing D68063 (llvm/CodeGen/CommandFlags.inc) and D73674 (llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp). Basic block sections is agreed to be useful even outside Properller.

There are several optimizations goals:

  • Alignment inserting
  • Automatic cache prefetching
  • Large code model addressing can lower performance quite a bit. A post-link scheme can relax large code model addressting to small code model addressing.
  • ...

    There is a CPU erratum that we want to mitigate.
  • Intel's Jump Condition Code Erratum

    By making this change, we will go the object file level route: annotate object files with metadata so that certain transformations can be performed.

    Whether this scheme can satisfy the goals and avoid the erratum, and the uncertainty about how many stuff we will have to reinvent is my biggest concerns.

    On https://lists.llvm.org/pipermail/llvm-dev/2020-February/139543.html (my brainstorming), I mentioned we may achieve our goals and make it suitable for future optimizations by using a file format with more semantics (rather than an object file). I hope we can think more on this, rather than rush to conclusions "this is redoing full LTO. it can't scale"

    Considering the above points, I re-iterate my "Request Changes". We need a plan to prove that we can achieve our optimization goals while avoiding caveats (erratum).
Mon, Mar 23, 10:21 AM · Restricted Project, lld

Sat, Mar 21

tmsriram updated the diff for D73307: Unique Names for Functions with Internal Linkage.

Address @rnk comments:

Sat, Mar 21, 5:38 PM
tmsriram added inline comments to D73307: Unique Names for Functions with Internal Linkage.
Sat, Mar 21, 5:38 PM

Fri, Mar 20

tmsriram added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

@echristo Eric, is this alright now? Thanks.

Fri, Mar 20, 3:12 PM · Restricted Project, lld

Thu, Mar 19

tmsriram added inline comments to D73307: Unique Names for Functions with Internal Linkage.
Thu, Mar 19, 3:54 PM
tmsriram updated the summary of D73307: Unique Names for Functions with Internal Linkage.
Thu, Mar 19, 2:14 PM
tmsriram added inline comments to D73307: Unique Names for Functions with Internal Linkage.
Thu, Mar 19, 2:14 PM
tmsriram updated the diff for D73307: Unique Names for Functions with Internal Linkage.

Address reviewer comments.

Thu, Mar 19, 2:14 PM
tmsriram added inline comments to D73307: Unique Names for Functions with Internal Linkage.
Thu, Mar 19, 1:09 PM
tmsriram added a reviewer for D73307: Unique Names for Functions with Internal Linkage: efriedma.
Thu, Mar 19, 10:51 AM
tmsriram updated the diff for D73307: Unique Names for Functions with Internal Linkage.

Address reviewer comments. Fix test and delete blank line.

Thu, Mar 19, 10:17 AM

Wed, Mar 18

tmsriram updated the summary of D73307: Unique Names for Functions with Internal Linkage.
Wed, Mar 18, 5:24 PM
tmsriram removed a parent revision for D73307: Unique Names for Functions with Internal Linkage: D68049: Propeller: Clang options for basic block sections .
Wed, Mar 18, 5:24 PM
tmsriram removed a child revision for D68049: Propeller: Clang options for basic block sections : D73307: Unique Names for Functions with Internal Linkage.
Wed, Mar 18, 5:24 PM · Restricted Project
tmsriram updated the diff for D73307: Unique Names for Functions with Internal Linkage.

Address Reviewer comments:

Wed, Mar 18, 5:23 PM
tmsriram added inline comments to D73307: Unique Names for Functions with Internal Linkage.
Wed, Mar 18, 5:23 PM

Tue, Mar 17

tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Address Reviewer comments.

Tue, Mar 17, 4:13 PM · Restricted Project, lld
tmsriram added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

In general I think a lot of this looks pretty good. It could use some more comments - in particular to call out what a lot of this code is used for. It's not used on a typical linking path and so could be confusing to people going through the code.

-eric

Tue, Mar 17, 4:13 PM · Restricted Project, lld

Mon, Mar 16

tmsriram committed rGc3f0ceab0fdf: Add target to test basicblock-sections-mir-parse.mir (authored by tmsriram).
Add target to test basicblock-sections-mir-parse.mir
Mon, Mar 16, 6:36 PM
tmsriram committed rGdf082ac45aa0: Basic Block Sections support in LLVM. (authored by tmsriram).
Basic Block Sections support in LLVM.
Mon, Mar 16, 4:25 PM
tmsriram closed D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).
Mon, Mar 16, 4:25 PM · Restricted Project

Sat, Mar 14

tmsriram committed rG4dfe92e46542: Basic Block Sections Support. (authored by tmsriram).
Basic Block Sections Support.
Sat, Mar 14, 6:49 PM
tmsriram closed D68063: Propeller: LLVM support for basic block sections.
Sat, Mar 14, 6:49 PM · Restricted Project
tmsriram committed rG2efeff6ac4a2: Test commit. (authored by tmsriram).
Test commit.
Sat, Mar 14, 6:16 PM

Fri, Mar 13

tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Fix the comment for the option basicblock-sections.

Fri, Mar 13, 3:40 PM · Restricted Project

Thu, Mar 12

tmsriram added a comment to D68063: Propeller: LLVM support for basic block sections.

Please still consider my suggestion that removes unrelated paragraphs from the summary :)

Thu, Mar 12, 1:34 PM · Restricted Project
tmsriram updated the summary of D68063: Propeller: LLVM support for basic block sections.
Thu, Mar 12, 1:04 PM · Restricted Project

Wed, Mar 11

tmsriram added a reviewer for D68065: Propeller: LLD Support for Basic Block Sections: echristo.
Wed, Mar 11, 6:54 PM · Restricted Project, lld
tmsriram updated subscribers of D68063: Propeller: LLVM support for basic block sections.

@eli.friedman @echristo Is this patch alright? I have added detailed comments as suggested by Eric to BBSectionsPrepare.cpp in https://reviews.llvm.org/D73674#change-lCLJRdamtrcE Thanks!

Wed, Mar 11, 10:09 AM · Restricted Project

Tue, Mar 10

tmsriram updated the diff for D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).
  • Change to use MemoryBuffer rather than string for bbsections file
  • Detailed comments in BBSectionsPrepare.cpp on basic block sections
Tue, Mar 10, 5:33 PM · Restricted Project
tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Address Reviewer comments:

Tue, Mar 10, 4:27 PM · Restricted Project

Mon, Mar 9

tmsriram added a comment to D68063: Propeller: LLVM support for basic block sections.

To be clear I think this is close to being acceptable

Agreed. I am still waiting for the resolution to my (very old) comment about:

Mon, Mar 9, 7:26 PM · Restricted Project
tmsriram added a comment to D68063: Propeller: LLVM support for basic block sections.

In LLVM core libraries, we generally want to accommodate use-cases that don't involve writing files to disk. This makes it easier to write tools targeting new use-cases. Here, for example, someone might want to try writing a JIT using a Propeller workflow. If SampleProfileLoader isn't supporting that, it should probably be fixed.

Mechanically, this seems fine... but it's also okay if we end up with a bit of similar code in multiple places. llc option parsing vs. lld option parsing is two distinct operations.

Mon, Mar 9, 5:50 PM · Restricted Project
tmsriram added a comment to D68063: Propeller: LLVM support for basic block sections.

Also the commit message is awesome, but would be good to get the commit message represented as comments in lots of the final code if possible :)

Mon, Mar 9, 5:17 PM · Restricted Project
tmsriram added a comment to D68063: Propeller: LLVM support for basic block sections.

Couple of inline comments. I'm trying pretty hard to be able to get rid of TargetOptions.h some day if possible. Any thoughts on ways to do this without?

Mon, Mar 9, 5:17 PM · Restricted Project
tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Address Reviewer comments.

Mon, Mar 9, 4:12 PM · Restricted Project
tmsriram added a comment to D68063: Propeller: LLVM support for basic block sections.

I'm not completely comfortable passing the BB-sections list to the backend as a file path; generally we try to allow the "frontend" (clang/llc/etc.) to control all file I/O. But I'm not sure what the alternative looks like. I guess we could pass it as MemoryBuffer?

Otherwise looks fine.

Mon, Mar 9, 11:52 AM · Restricted Project

Thu, Mar 5

tmsriram added a comment to D68063: Propeller: LLVM support for basic block sections.

@efriedma : Hi Eli, this is the parent patch of D73674. Appreciate if you could take a look at this too, thanks!

Thu, Mar 5, 10:22 AM · Restricted Project

Wed, Mar 4

tmsriram updated the diff for D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).

Rebase, address reviewer comments.

Wed, Mar 4, 7:03 PM · Restricted Project

Tue, Mar 3

tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Rebase.

Tue, Mar 3, 3:33 PM · Restricted Project

Mar 1 2020

tmsriram updated the diff for D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).

Add support for serializing Basic Block Section Type.

Mar 1 2020, 8:41 PM · Restricted Project

Feb 27 2020

tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

The number of relocations per input section with basic blocks is a few, eyeballing it is about 3-4 relocations including the extra jump relocation that gets added.

Feb 27 2020, 5:23 PM · Restricted Project, lld

Feb 26 2020

tmsriram added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

A Phabricator tip: marking every review comment Not applicable. is not needed. You can just click "Close" (status: Unsubmitted) but don't click Submit. When you upload a new Diff (with arc diff), the comments will be closed automatically.

Feb 26 2020, 4:54 PM · Restricted Project, lld
tmsriram added a parent revision for D68065: Propeller: LLD Support for Basic Block Sections: D68063: Propeller: LLVM support for basic block sections.
Feb 26 2020, 4:45 PM · Restricted Project, lld
tmsriram added a child revision for D68063: Propeller: LLVM support for basic block sections: D68065: Propeller: LLD Support for Basic Block Sections.
Feb 26 2020, 4:45 PM · Restricted Project
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Fix symbol shrinking code to incorporate reviewer comments.

Feb 26 2020, 12:47 PM · Restricted Project, lld

Feb 25 2020

tmsriram added inline comments to D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).
Feb 25 2020, 9:31 PM · Restricted Project
tmsriram added inline comments to D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).
Feb 25 2020, 5:33 PM · Restricted Project
tmsriram added a comment to D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).

I'm afraid the way this patch is written, we're going to have to substantially rewrite it to port to other targets. In particular, we're assigning blocks to sections in the asmprinter, which is way too late for targets that do branch relaxation as an MIR pass.

Hi Eli, What do you suggest we do here? An MIR pass that assigns sections to basic blocks?

Yes, that would make sense. Not completely sure where it should run, but we can adjust that later. Maybe we want it to happen before MachineBlockPlacement, so we can do section-aware block placement?

Feb 25 2020, 5:30 PM · Restricted Project
tmsriram updated the diff for D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).

Create a new pass and assign sections to Machine Basic Blocks in this pass.

Feb 25 2020, 5:30 PM · Restricted Project
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Address reviewer comments, new test for PC32 reloc.

Feb 25 2020, 3:23 PM · Restricted Project, lld
tmsriram added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 25 2020, 3:23 PM · Restricted Project, lld
tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Deleted changes to CodeGenPrepare.cpp, Function.*.

Feb 25 2020, 7:38 AM · Restricted Project

Feb 24 2020

tmsriram added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

40+ comments have not been addressed.

Feb 24 2020, 8:48 PM · Restricted Project, lld

Feb 14 2020

tmsriram added a comment to D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).

I'm afraid the way this patch is written, we're going to have to substantially rewrite it to port to other targets. In particular, we're assigning blocks to sections in the asmprinter, which is way too late for targets that do branch relaxation as an MIR pass.

Hi Eli, What do you suggest we do here? An MIR pass that assigns sections to basic blocks?

Yes, that would make sense. Not completely sure where it should run, but we can adjust that later. Maybe we want it to happen before MachineBlockPlacement, so we can do section-aware block placement?

Is there some reason to emit "cold" and "exception" blocks into separate sections? Not sure what benefit you get from separating them.

Sections containing hot blocks can be grouped together, function splitting of cold basic blocks and placing all the cold blocks together and away from the hot blocks gives us better iTLB utilization.

I meant, is there some reason to emit "cold" and "exception" sections separately from each other. I understand the benefit of separating both of them from the hot blocks.

Feb 14 2020, 4:03 PM · Restricted Project
tmsriram added a comment to D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).

I'm afraid the way this patch is written, we're going to have to substantially rewrite it to port to other targets. In particular, we're assigning blocks to sections in the asmprinter, which is way too late for targets that do branch relaxation as an MIR pass.

Feb 14 2020, 2:30 PM · Restricted Project
tmsriram added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 14 2020, 11:35 AM · Restricted Project, lld
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Add tests for more jmp opcodes other nits.

Feb 14 2020, 11:35 AM · Restricted Project, lld

Feb 13 2020

tmsriram added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 13 2020, 11:56 AM · Restricted Project, lld
tmsriram added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 13 2020, 11:46 AM · Restricted Project, lld
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Address reviewer comments.

Feb 13 2020, 11:46 AM · Restricted Project, lld

Feb 12 2020

tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Add a test for ICF with bb sections.

Feb 12 2020, 5:26 PM · Restricted Project, lld
tmsriram added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 12 2020, 5:26 PM · Restricted Project, lld
tmsriram added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 12 2020, 4:40 PM · Restricted Project, lld
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Address reviewer comments, camel case, delete and rename methods.

Feb 12 2020, 4:40 PM · Restricted Project, lld

Feb 11 2020

tmsriram added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 11 2020, 4:46 PM · Restricted Project, lld
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Modify handling of NOP Filler.

Feb 11 2020, 4:46 PM · Restricted Project, lld
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Rename JumpRelocations to JumpInstrMods. As per Rui's suggestion, relocations have a specific meaning and these c modifiers to jump instructions should not be confused with actual relocations.

Feb 11 2020, 3:53 PM · Restricted Project, lld
tmsriram removed a parent revision for D73310: Allow Module name to be used to generate a unique Module ID: D68063: Propeller: LLVM support for basic block sections.
Feb 11 2020, 12:42 PM · Restricted Project
tmsriram removed a child revision for D68063: Propeller: LLVM support for basic block sections: D73310: Allow Module name to be used to generate a unique Module ID.
Feb 11 2020, 12:42 PM · Restricted Project
tmsriram added a child revision for D68063: Propeller: LLVM support for basic block sections: D68049: Propeller: Clang options for basic block sections .
Feb 11 2020, 12:42 PM · Restricted Project
tmsriram added parent revisions for D68049: Propeller: Clang options for basic block sections : D68063: Propeller: LLVM support for basic block sections, D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2).
Feb 11 2020, 12:42 PM · Restricted Project
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Remove reference to "propeller" from this patch. This is LLD support for basic block sections.

Feb 11 2020, 12:42 PM · Restricted Project, lld
tmsriram added a child revision for D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2): D68049: Propeller: Clang options for basic block sections .
Feb 11 2020, 12:42 PM · Restricted Project
tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

I think the patch series should probably be structured this way:

  1. LLVM CodeGen: enables basic block sections.
  2. clang Driver/Frontend/CodeGen: pass basic block sections options to LLVM.
  3. LLVM CodeGen: which enables the rest of Propeller options.
  4. lld: a file similar to lld/ELF/LTO.cpp . It should be a thin wrapper of Propeller features. It should not do hacky diassembly tasks.
  5. clang Driver/Frontend/CodeGen: passes compiler/linker options to 3 and 4

    Making 1 and 2 separate can help move forward the patch series. 1 and 2 should not reference llvm::propeller.
Feb 11 2020, 12:15 PM · Restricted Project
tmsriram updated the diff for D68049: Propeller: Clang options for basic block sections .

Remove usage of "propeller". Fix header inclusion.

Feb 11 2020, 12:15 PM · Restricted Project
tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

In D68049#1865967, @MaskRay wrote:
If you don't mind, I can push a Diff to this Differential which will address these review comments.

I can't because I can't figure out the patch relationship...

First, this patch does not build on its own. I try applying D68063 first, then this patch. It still does not compile..

Feb 11 2020, 12:15 PM · Restricted Project
tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Remove usage of "propeller" from this patch, this is only about support for basic block sections.

Feb 11 2020, 11:56 AM · Restricted Project
tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

In D68049#1865967, @MaskRay wrote:
If you don't mind, I can push a Diff to this Differential which will address these review comments.

I can't because I can't figure out the patch relationship...

First, this patch does not build on its own. I try applying D68063 first, then this patch. It still does not compile..

Feb 11 2020, 10:23 AM · Restricted Project
tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

In D68049#1865967, @MaskRay wrote:
If you don't mind, I can push a Diff to this Differential which will address these review comments.

I can't because I can't figure out the patch relationship...

First, this patch does not build on its own. I try applying D68063 first, then this patch. It still does not compile..

Feb 11 2020, 10:15 AM · Restricted Project

Feb 10 2020

tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Use MemoryBuffer::getFile instead of fstream.

Feb 10 2020, 3:20 PM · Restricted Project
tmsriram updated the diff for D68049: Propeller: Clang options for basic block sections .

Removed getBBSectionsList (moved to LLVM) and address other reviewer comments.

Feb 10 2020, 10:13 AM · Restricted Project
tmsriram added a reviewer for D68049: Propeller: Clang options for basic block sections : grimar.
Feb 10 2020, 10:13 AM · Restricted Project
tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

If you don't mind, I can push a Diff to this Differential which will address these review comments.

Feb 10 2020, 9:41 AM · Restricted Project

Feb 7 2020

tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Address reviewer comments.

Feb 7 2020, 4:32 PM · Restricted Project, lld

Feb 6 2020

tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Rebase and rename PropellerProf to BBSectionsProf.

Feb 6 2020, 3:56 PM · Restricted Project
tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.

Rebase and make some suggested fixes.

Feb 6 2020, 3:29 PM · Restricted Project, lld
tmsriram updated the diff for D68063: Propeller: LLVM support for basic block sections.

Address reviewer comments. Delete changes to BasicBlock.h.

Feb 6 2020, 11:56 AM · Restricted Project