Page MenuHomePhabricator

tmsriram (Sriraman Tallam)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2016, 10:26 AM (363 w, 1 d)

Recent Activity

Jan 3 2023

tmsriram added a comment to D140478: [RISCV] For Dwarf v5, emit indices into .debug_addr for range list entries.

Is there any mechanism that tests whether a given range bounded by two labels may be subject to linker relaxation? It'd be nice to have that abstraction and use it here (& in some other places in DWARF emission) rather than hardcoding one particular architecture.

Unless the relaxations are performed during the assembling, this may not be possible before linking because we will not know which set of labels have instruction sequence(s) that the linker actually might be able to relax after finishing the section layout.
So, depending on whether linker relaxations are enabled, I think we can only either emit relocatable symbols for all the range labels or never.

Yeah, such a query wouldn't have to be precise, only conservatively correct - so if you can't be sure a given range won't be relaxed, then the query would say that it might be & DWARF would be emitted that'd be resilient to such relaxation.

The other place this would be needed is in the low/high_pc computation, since currently, even in DWARFv4, the high_pc is encoded as a delta from low_pc, not as a separate relocatable label, so that'd need the same checking.

I have introduced a new MCAsmInfo API to check if we need relocatable symbol references in dwarf entries based on whether the linker relaxations are enabled.

Is there any mechanism that tests whether a given range bounded by two labels may be subject to linker relaxation? It'd be nice to have that abstraction and use it here (& in some other places in DWARF emission) rather than hardcoding one particular architecture.

The other place this would be needed is in the low/high_pc computation, since currently, even in DWARFv4, the high_pc is encoded as a delta from low_pc, not as a separate relocatable label, so that'd need the same checking.

And I was thinking that PROPELLER needed/was considering doing some linker relaxation too, so could benefit from such an abstraction/hook/check - but maybe they didn't end up needing/using linker relaxation? (@tmsriram - did PROPELLER ever end up needing/using linker relaxation? is that still something under consideration?)

Propeller needs linker relaxation for branch instructions. Making it a shorter branch when the offset can fit in one byte and flipping branches, from like je to jne to convert and remove a subsequent fallthrough.

I remember dealing with issues regarding low_pc, high_pc. I think you reviewed these patches, I forget the details now and can take another look to see how this can help.

Hmm, yeah, I'm confused - because I'd expect the code for ranges to have to handle this but judging by the code being added in this patch, the code isn't already there that I'd expect to be there for linker relaxation in PROPELLER.

Could you point me to the reviews and/or a simple-ish example that would reproduce the relaxation behavior for PROPELLER so I can see how the DWARF is emitted/works uot?

Jan 3 2023, 11:31 AM · Restricted Project, Restricted Project

Dec 21 2022

tmsriram added a comment to D140478: [RISCV] For Dwarf v5, emit indices into .debug_addr for range list entries.

Is there any mechanism that tests whether a given range bounded by two labels may be subject to linker relaxation? It'd be nice to have that abstraction and use it here (& in some other places in DWARF emission) rather than hardcoding one particular architecture.

The other place this would be needed is in the low/high_pc computation, since currently, even in DWARFv4, the high_pc is encoded as a delta from low_pc, not as a separate relocatable label, so that'd need the same checking.

And I was thinking that PROPELLER needed/was considering doing some linker relaxation too, so could benefit from such an abstraction/hook/check - but maybe they didn't end up needing/using linker relaxation? (@tmsriram - did PROPELLER ever end up needing/using linker relaxation? is that still something under consideration?)

Dec 21 2022, 10:51 AM · Restricted Project, Restricted Project

Dec 16 2022

tmsriram updated the diff for D140252: Cmake config for Propeller Optimized Clang.

Added more comments.

Dec 16 2022, 4:22 PM · Restricted Project
tmsriram updated the diff for D140252: Cmake config for Propeller Optimized Clang.

Add Propeller.cmake config

Dec 16 2022, 4:17 PM · Restricted Project
tmsriram requested review of D140252: Cmake config for Propeller Optimized Clang.
Dec 16 2022, 4:11 PM · Restricted Project

Dec 6 2022

tmsriram accepted D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number..

LGTM. Please make sure all reviewers have approved the patch.

Dec 6 2022, 3:59 PM · Restricted Project, Restricted Project
tmsriram added inline comments to D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number..
Dec 6 2022, 1:34 PM · Restricted Project, Restricted Project

Nov 23 2022

tmsriram accepted D138616: [NFC] Use BB->size() instead of BB->getInstList().size()..

LGTM

Nov 23 2022, 4:37 PM · Restricted Project, Restricted Project
tmsriram accepted D138617: [NFC] Replaced BB->getInstList().{erase(),pop_front(),pop_back()} with eraseFromParent()..

LGTM

Nov 23 2022, 4:36 PM · Restricted Project, Restricted Project
tmsriram accepted D138620: [NFC] Replaced BB->getInstList().front() with BB->front().

LGTM

Nov 23 2022, 4:31 PM · Restricted Project, Restricted Project

Oct 14 2022

tmsriram accepted D135926: [clang] Fix crash with -funique-internal-linkage-names.

LGTM, thanks for fixing this!

Oct 14 2022, 8:41 PM · Restricted Project, Restricted Project

Sep 30 2022

tmsriram committed rG90f2c768e59a: Unittest to skip padding between buildid and filenames. (authored by tmsriram).
Unittest to skip padding between buildid and filenames.
Sep 30 2022, 12:45 PM · Restricted Project
tmsriram closed D130563: Skip padding between buildid and filenames..
Sep 30 2022, 12:44 PM · Restricted Project, Restricted Project

Aug 25 2022

tmsriram accepted D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation.
Aug 25 2022, 2:49 PM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2022

tmsriram committed rG3e43d0cde719: This patch fixes these errors while building BOLT. (authored by tmsriram).
This patch fixes these errors while building BOLT.
Aug 2 2022, 11:24 AM · Restricted Project
tmsriram closed D130402: Fix BOLT build errors when building with Bazel build file.
Aug 2 2022, 11:23 AM · Restricted Project, Restricted Project

Jul 22 2022

tmsriram updated the diff for D130402: Fix BOLT build errors when building with Bazel build file.

Delete forward declaration to BinaryBasicBlock.

Jul 22 2022, 4:38 PM · Restricted Project, Restricted Project
tmsriram requested review of D130402: Fix BOLT build errors when building with Bazel build file.
Jul 22 2022, 4:33 PM · Restricted Project, Restricted Project

Jul 19 2022

tmsriram committed rG116ee23f4cc6: [bolt] std::atomic_uint64_t to std::atomic<uint64_t> (authored by tmsriram).
[bolt] std::atomic_uint64_t to std::atomic<uint64_t>
Jul 19 2022, 4:12 PM · Restricted Project
tmsriram closed D129903: Use std::atomic<std::uint64_t> instead of std::atomic_uint64_t.
Jul 19 2022, 4:12 PM · Restricted Project, Restricted Project
tmsriram committed rG16cccc66b8be: Bazel BUILD file for BOLT. (authored by tmsriram).
Bazel BUILD file for BOLT.
Jul 19 2022, 4:06 PM · Restricted Project
tmsriram closed D129899: Bazel BUILD file for BOLT.
Jul 19 2022, 4:06 PM · Restricted Project, Restricted Project
tmsriram updated the summary of D129899: Bazel BUILD file for BOLT.
Jul 19 2022, 3:56 PM · Restricted Project, Restricted Project

Jul 15 2022

tmsriram updated subscribers of D129903: Use std::atomic<std::uint64_t> instead of std::atomic_uint64_t.

clang -v of the failing command:
clang -cc1 version 11.0.0 based upon LLVM 11.0.0git default target
x86_64-unknown-linux-gnu

Jul 15 2022, 2:25 PM · Restricted Project, Restricted Project
tmsriram requested review of D129903: Use std::atomic<std::uint64_t> instead of std::atomic_uint64_t.
Jul 15 2022, 2:01 PM · Restricted Project, Restricted Project
tmsriram updated the diff for D129899: Bazel BUILD file for BOLT.

Splitting the changes.

Jul 15 2022, 1:57 PM · Restricted Project, Restricted Project
tmsriram requested review of D129899: Bazel BUILD file for BOLT.
Jul 15 2022, 12:55 PM · Restricted Project, Restricted Project

May 23 2022

tmsriram accepted D125426: Add a new flavor "BBLabels" to LLVM_BUILD_INSTRUMENTED.

This LGTM, please address hans' comments.

May 23 2022, 10:59 AM · Restricted Project, Restricted Project

May 12 2022

tmsriram added a comment to D125426: Add a new flavor "BBLabels" to LLVM_BUILD_INSTRUMENTED.

Here is the proposed workflow to build a propeller optimized clang binary (similar to PGO build).

  1. Build instrumented clang binary:

cmake -G Ninja ... -DLLVM_BUILD_INSTRUMENTED=BBLabels ... llvm-project/llvm
ninja build

  1. Using the above built binary in day-to-day routine and collect perf.data file and then convert it to propeller profiles.
  1. Build the optimized clang binary:

cmake -G Ninja ... -DLLVM_PROPELLER_PROFILES=<profile> ... llvm-project/llvm

The experiment data show propeller optimized clang has a 5% compiler time improvement over PGO build.

May 12 2022, 11:30 AM · Restricted Project, Restricted Project

Dec 20 2021

tmsriram requested review of D116054: Avoid duplicating uniqueness in ThinLTO when unique internal linkage names are used.
Dec 20 2021, 12:57 PM · Restricted Project

Jul 26 2021

tmsriram accepted D106421: Encode address offsets of basic blocks relative to the end of the previous basic blocks..

LGTM

Jul 26 2021, 10:02 AM · Restricted Project

Jun 30 2021

tmsriram accepted D105226: [Clang] allow overriding -fbasic-block-sections.

LGTM

Jun 30 2021, 2:02 PM · Restricted Project

Jun 15 2021

tmsriram added inline comments to D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
Jun 15 2021, 11:32 AM · Restricted Project, Restricted Project

Jun 1 2021

tmsriram committed rG516e5bb2b11e: Resubmit D85085 after fixing the tests that were failing. (authored by tmsriram).
Resubmit D85085 after fixing the tests that were failing.
Jun 1 2021, 10:01 PM

May 26 2021

tmsriram committed rGcaae570978c4: Emit correct location lists with basic block sections. (authored by tmsriram).
Emit correct location lists with basic block sections.
May 26 2021, 5:16 PM
tmsriram closed D85085: Fix debug_loc offset difference with basic block sections.
May 26 2021, 5:16 PM · Restricted Project

May 24 2021

tmsriram added inline comments to D85085: Fix debug_loc offset difference with basic block sections.
May 24 2021, 6:17 PM · Restricted Project
tmsriram added inline comments to D85085: Fix debug_loc offset difference with basic block sections.
May 24 2021, 6:16 PM · Restricted Project
tmsriram updated the diff for D85085: Fix debug_loc offset difference with basic block sections.

Address reviewer comments:

May 24 2021, 6:15 PM · Restricted Project

May 21 2021

tmsriram added a comment to D102900: [llvm-readobj] Print function names with `--bb-addr-map`..

The quadratic behavior leading to a 10 minute latency is too much. Binary search like you mentioned or just hash look up seems like it would drastically reduce the problem, could we bake it in the same change?

May 21 2021, 7:56 PM · Restricted Project

Apr 29 2021

tmsriram committed rGa64411916cc8: Basic block sections for functions with implicit-section-name attribute (authored by tmsriram).
Basic block sections for functions with implicit-section-name attribute
Apr 29 2021, 12:30 PM
tmsriram closed D101311: Basic block sections for functions with implicit-section-name attribute.
Apr 29 2021, 12:30 PM · Restricted Project

Apr 28 2021

tmsriram added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

Agree with @MaskRay I'd like to see a holistics plan/RFC on all the pieces that are needed to get this functionality. The functionality here is only tested when exceptions are actually propagated which is not common in LLVM test suite. You'll want to run and likely write very specific tests stressing the test matrix here of BBS + MFS + EH. Given all that, a larger plan that details how we can be confident that all the pieces have been accounted for and will be well tested is (IMO) imperative in getting this change reviewed and accepted.

Apr 28 2021, 9:18 PM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2021

tmsriram added inline comments to D101311: Basic block sections for functions with implicit-section-name attribute.
Apr 27 2021, 7:54 PM · Restricted Project
tmsriram updated the diff for D101311: Basic block sections for functions with implicit-section-name attribute.

Address reviewer comments:

Apr 27 2021, 7:54 PM · Restricted Project
tmsriram added a comment to D85085: Fix debug_loc offset difference with basic block sections.

Thanks for this - tests generally look great. Code mostly makes sense to me (that's on me, not you) - couple of minor quibbles with comment wording, but nothing major I think.

Apr 27 2021, 3:32 PM · Restricted Project
tmsriram updated the diff for D85085: Fix debug_loc offset difference with basic block sections.

Address reviewer comments:

Apr 27 2021, 3:31 PM · Restricted Project

Apr 26 2021

tmsriram added inline comments to D101311: Basic block sections for functions with implicit-section-name attribute.
Apr 26 2021, 8:53 PM · Restricted Project
tmsriram requested review of D101311: Basic block sections for functions with implicit-section-name attribute.
Apr 26 2021, 10:51 AM · Restricted Project

Apr 21 2021

tmsriram added a comment to D99693: Update the linkage name of coro-split functions where applicable.

This patch does not affect C++ coroutines, since the DW_AT_specification is expected to hold the (original) linkage name.

So does this mean that for C++ we'll have a DW_TAG_subprogram with a DW_AT_linkage_name that doesn't match the symbol for that code in the object's symbol table?

Correct — and I would say this is probably a bug, unless we want DW_AT_linkage_name to show the "original" linkage name for purposes of matching breakpoints refering to the original name without the .resume suffix or something like that.

I'm a bit confused then.

since the DW_AT_specification is expected to hold the (original) linkage name.

What's this claim ^ about/based on? What happens if it doesn't hold the original linkage name?

@tmsriram - I think you hit a problem with debug info linkage names not matching the symbol names in the unique linkage name work. Do you recall what the problem was when those things diverged?

Apr 21 2021, 5:04 PM · Restricted Project

Apr 19 2021

tmsriram added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

This is quite important to validate the correctness of the generated assembly. If you could please check that CFI and DebugInfo are sane before we take this patch forward? Let's get a temperature on how good these are before we decide how to take it forward.

Thanks! I got the importance.
As for DebugInfo, I tried to add "--basic-block-sections=all" to RUN of llvm/test/DebugInfo/COFF/comdat.ll, text sections includes basic block text sections and CodeViewDebugInfo can be created correctly after

  1. apply this patch
  2. commenting out a Linux exception handling protocol dependent function which I plan to do in later basic block section Windows exception handling patch.

There are some non-blocking errors "error: all .cv_loc directives for a function must be in the same section" in llc stage, one error for each basic block, below is the first one.
f.__part.1: # %if.then
#DEBUG_VALUE: f:c <- $ecx
<unknown>:0: error: all .cv_loc directives for a function must be in the same section
.Ltmp3:

Would you be able to paste the entire assembly with cv loc directives? I can try to take a look.

As for CFI, does it need be verified addition to llvm/test/DebugInfo/ tests? If so, could you please guide me how CFI of basic block sections is verified on Linux?

Basically, this means your code won't assemble with CFI and that is a serious limitation. This is similar to what we did for ELF. All CFI directives should be within a cfi_startproc cfi_endproc directive as part of a single section. When you fragment a function into multiple sections, this breaks. We solved this by adding a separate startproc endproc directive for each section.

I have some suggestions for you to better understand the problem:

  • GCC supports function splitting with -freorder-blocks-and-partition. You can use GCC to split a function and see what it does to cv_loc directives.
  • D79978 is what we did with ELF, my guess is it is very similar. You just need to add a startproc endproc to every function and duplicate all the information to compute Call Frame Address.
Apr 19 2021, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 18 2021

tmsriram added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

This is quite important to validate the correctness of the generated assembly. If you could please check that CFI and DebugInfo are sane before we take this patch forward? Let's get a temperature on how good these are before we decide how to take it forward.

Thanks! I got the importance.
As for DebugInfo, I tried to add "--basic-block-sections=all" to RUN of llvm/test/DebugInfo/COFF/comdat.ll, text sections includes basic block text sections and CodeViewDebugInfo can be created correctly after

  1. apply this patch
  2. commenting out a Linux exception handling protocol dependent function which I plan to do in later basic block section Windows exception handling patch.

There are some non-blocking errors "error: all .cv_loc directives for a function must be in the same section" in llc stage, one error for each basic block, below is the first one.
f.__part.1: # %if.then
#DEBUG_VALUE: f:c <- $ecx
<unknown>:0: error: all .cv_loc directives for a function must be in the same section
.Ltmp3:

Apr 18 2021, 11:57 PM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2021

tmsriram added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

If it is easier for you to break this up, you can present exception handling in a separate patch with a clear "TODO:" at the appropriate places. That should be alright and is also easier to review.

I added "TODO:" for constructing exception section and cold section later.

Great, please use the parent-child relationships to mark these patches.

I marked parent-child relationships.

  • Could you also please expand the summary of this patch? I would write what extra was needed to port this from ELF to PE-COFF.

I expanded the summary, could you please have a review?

  • Could you also talk about DebugInfo handling and CFI with PE-COFF and basic block sections? Are these format agnostic and have you verified that they do the right thing? These were the biggest challenges for us when doing this for ELF.

No, I didn't verify DebugInfo handling and CFI with PE-COFF and basic block sections.

Apr 14 2021, 5:04 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2021

tmsriram added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

Hi tmsriram, MaskRay,

I updated implementation and test. Could you please have a look?
As for multiple COMDAT seletion kinds of PE-COFF, is IMAGE_COMDAT_SELECT_NODUPLICATES wrong? Or need to set different COMDAT selection kind in some case?

Apr 13 2021, 7:06 PM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2021

tmsriram updated the diff for D85085: Fix debug_loc offset difference with basic block sections.

Address reviewer comments on adding various test cases to make sure loc lists are generated the same way with and without basic block sections except when the ranges cross section boundaries.

Apr 9 2021, 9:36 PM · Restricted Project

Mar 31 2021

tmsriram added inline comments to D99487: [CodeGen] Port basic block sections from ELF to COFF.
Mar 31 2021, 3:39 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2021

tmsriram added inline comments to D99487: [CodeGen] Port basic block sections from ELF to COFF.
Mar 29 2021, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2021

tmsriram accepted D99395: [Propeller] Do not generate the BB address map for empty functions..
Mar 25 2021, 8:06 PM · Restricted Project
tmsriram added inline comments to D99395: [Propeller] Do not generate the BB address map for empty functions..
Mar 25 2021, 7:22 PM · Restricted Project
tmsriram accepted D99316: Add missing 'CHECK' prefix to basic block labels test..
Mar 25 2021, 4:02 PM · Restricted Project

Mar 22 2021

tmsriram accepted D96918: [llvm-readelf, propeller] Add fallthrough bit to basic block metadata in BB-Address-Map section..

LGTM and is a simple change to capture the fall through bit.

Mar 22 2021, 3:37 PM · Restricted Project

Mar 18 2021

tmsriram added inline comments to D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name..
Mar 18 2021, 12:15 PM · Restricted Project

Mar 11 2021

tmsriram committed rGcdb42a4cc423: Disable unique linkage suffixes ifor global vars until demanglers can be fixed. (authored by tmsriram).
Disable unique linkage suffixes ifor global vars until demanglers can be fixed.
Mar 11 2021, 9:00 PM
tmsriram closed D98392: Disable Unique Internal Linkage Names for internal global vars.
Mar 11 2021, 9:00 PM · Restricted Project
tmsriram updated the diff for D98392: Disable Unique Internal Linkage Names for internal global vars.

Address reviewer comments and refactor code as mentioned.

Mar 11 2021, 7:31 PM · Restricted Project
tmsriram accepted D98389: [IndirectCallPromotion] Don't strip ".__uniq." suffix when it strips ".llvm." suffix..
Mar 11 2021, 10:33 AM · Restricted Project

Mar 10 2021

tmsriram abandoned D95902: TSAN module_ctor symbol name can change with -funique-internal-linkage-names.

D96109 moved the adding of suffixes to clang front end and this will not be an issue any more with llvm created functions.

Mar 10 2021, 9:48 PM · Restricted Project
tmsriram requested review of D98392: Disable Unique Internal Linkage Names for internal global vars.
Mar 10 2021, 9:34 PM · Restricted Project
tmsriram added inline comments to D98389: [IndirectCallPromotion] Don't strip ".__uniq." suffix when it strips ".llvm." suffix..
Mar 10 2021, 8:51 PM · Restricted Project
tmsriram committed rG0ba1ebcbb775: Remove original implementation of UniqueInternalLinkageNames pass. (authored by tmsriram).
Remove original implementation of UniqueInternalLinkageNames pass.
Mar 10 2021, 12:04 PM
tmsriram closed D98234: Delete original implementation of UniqueInternalLinkageNames pass.
Mar 10 2021, 12:04 PM · Restricted Project

Mar 8 2021

tmsriram requested review of D98234: Delete original implementation of UniqueInternalLinkageNames pass.
Mar 8 2021, 10:39 PM · Restricted Project

Mar 5 2021

tmsriram committed rG78d0e91865f6: Refactor -funique-internal-linakge-names implementation. (authored by tmsriram).
Refactor -funique-internal-linakge-names implementation.
Mar 5 2021, 1:35 PM
tmsriram closed D96109: Refactor implementation of -funique-internal-linkage-names..
Mar 5 2021, 1:34 PM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2021

tmsriram updated the diff for D96109: Refactor implementation of -funique-internal-linkage-names..

Address reviewer comment to use numeric substitution block.

Feb 23 2021, 9:09 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram added a comment to D96109: Refactor implementation of -funique-internal-linkage-names..

Looks good to me - maybe give it a week or so in case other reviewers have some unresolved concerns.

Feb 23 2021, 7:19 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram updated the diff for D96109: Refactor implementation of -funique-internal-linkage-names..

Address reviewer comments:

Feb 23 2021, 7:13 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram updated the summary of D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 23 2021, 7:11 PM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2021

tmsriram updated the diff for D96109: Refactor implementation of -funique-internal-linkage-names..

Address reviewer comments:

Feb 22 2021, 7:31 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram added inline comments to D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 22 2021, 12:35 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram added inline comments to D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 22 2021, 12:33 PM · Restricted Project, Restricted Project, Restricted Project

Feb 19 2021

tmsriram added a comment to D96932: [SampleFDO] Support enabling -funique-internal-linkage-name.

Thanks for doing this! Much appreciated!

Feb 19 2021, 7:02 PM · Restricted Project
tmsriram added inline comments to D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 19 2021, 5:20 PM · Restricted Project, Restricted Project, Restricted Project

Feb 18 2021

tmsriram updated the diff for D96109: Refactor implementation of -funique-internal-linkage-names..

Fix a bug.

Feb 18 2021, 11:26 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram updated the diff for D96109: Refactor implementation of -funique-internal-linkage-names..

Removed the atttribute and directly added logic in ItaniumMangle.cpp to check if decl is internal linkage as per @dblaikie 's suggestion.

Feb 18 2021, 10:59 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram added inline comments to D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 18 2021, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram added inline comments to D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 18 2021, 11:22 AM · Restricted Project, Restricted Project, Restricted Project
tmsriram added inline comments to D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 18 2021, 11:06 AM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2021

tmsriram added a reviewer for D96109: Refactor implementation of -funique-internal-linkage-names.: HAPPY.
Feb 17 2021, 4:49 PM · Restricted Project, Restricted Project, Restricted Project
tmsriram committed rGe74191633036: Basic block sections should enable not function sections implicitly. (authored by tmsriram).
Basic block sections should enable not function sections implicitly.
Feb 17 2021, 12:45 PM

Feb 16 2021

tmsriram committed rGd1a838babcc3: Basic block sections should enable function sections implicitly. (authored by tmsriram).
Basic block sections should enable function sections implicitly.
Feb 16 2021, 4:30 PM
tmsriram closed D93876: Do not implicitly turn on function sections with basic block sections..
Feb 16 2021, 4:30 PM · Restricted Project
tmsriram added inline comments to D93876: Do not implicitly turn on function sections with basic block sections..
Feb 16 2021, 12:29 PM · Restricted Project

Feb 15 2021

tmsriram added inline comments to D93876: Do not implicitly turn on function sections with basic block sections..
Feb 15 2021, 4:00 PM · Restricted Project

Feb 12 2021

tmsriram added inline comments to D93876: Do not implicitly turn on function sections with basic block sections..
Feb 12 2021, 10:06 PM · Restricted Project
tmsriram updated the diff for D93876: Do not implicitly turn on function sections with basic block sections..
Feb 12 2021, 10:06 PM · Restricted Project
tmsriram added inline comments to D96109: Refactor implementation of -funique-internal-linkage-names..
Feb 12 2021, 12:03 PM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2021

tmsriram updated the diff for D96109: Refactor implementation of -funique-internal-linkage-names..

This patch update handles the following:

Feb 11 2021, 3:53 PM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2021

tmsriram accepted D96392: [CodeGen] Basic block sections should take precedence over splitting..
Feb 9 2021, 8:49 PM · Restricted Project
tmsriram added inline comments to D96392: [CodeGen] Basic block sections should take precedence over splitting..
Feb 9 2021, 7:46 PM · Restricted Project