Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Is it always unnecessary or is there a possibility that it still might be (e.g., async pointer)?
Comment Actions
AsyncToLLVM lowering only supports std and llvm types. If the former is lowered to llvm but one of the uses expects a std type, the llvm type converter will already materialize an llvm.mlir.cast if needed.
But a manually created instance can be in the way if the async value type is already an llvm type, because llvm.mlir.cast doesn't currently have a folder that would remove a cast between equal types.
Please take my explanation with a grain of salt, my understanding is limited...