This is an archive of the discontinued LLVM Phabricator instance.

Differential D94314

[clangd] Add missing "override" to fix the build.
ClosedPublic

Authored by adamcz on Jan 8 2021, 8:21 AM.

Details

Reviewers
kadircet
Commits
rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build.
Summary

Follow-up to d4af86581e80ef0f7a6f4a4fff1c97260a726e71

Diff Detail

Event Timeline

adamcz created this revision.Jan 8 2021, 8:21 AM
Herald added subscribers: usaxena95, kadircet, arphaman. · View Herald TranscriptJan 8 2021, 8:21 AM
adamcz requested review of this revision.Jan 8 2021, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 8:21 AM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
adamcz added a reviewer: kadircet.Jan 8 2021, 8:22 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2021, 8:26 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build. (authored by adamcz). · Explain Why
This revision was automatically updated to reflect the committed changes.
adamcz added a commit: rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build..
Harbormaster completed remote builds in B84480: Diff 315411.Jan 8 2021, 10:02 AM

Revision Contents

PathSize
clang-tools-extra/
clangd/
2 lines

Diff 315412

clang-tools-extra/clangd/AST.cpp

Show First 20 Lines • Show All 304 Lines • ▼ Show 20 Linesstd::string printType(const QualType QT, const DeclContext &CurContext) {
PrintingPolicy PP(CurContext.getParentASTContext().getPrintingPolicy()); PrintingPolicy PP(CurContext.getParentASTContext().getPrintingPolicy());
PP.SuppressTagKeyword = true; PP.SuppressTagKeyword = true;
PP.SuppressUnwrittenScope = true; PP.SuppressUnwrittenScope = true;
class PrintCB : public PrintingCallbacks { class PrintCB : public PrintingCallbacks {
public: public:
PrintCB(const DeclContext *CurContext) : CurContext(CurContext) {} PrintCB(const DeclContext *CurContext) : CurContext(CurContext) {}
virtual ~PrintCB() {} virtual ~PrintCB() {}
virtual bool isScopeVisible(const DeclContext *DC) const { virtual bool isScopeVisible(const DeclContext *DC) const override {
return DC->Encloses(CurContext); return DC->Encloses(CurContext);
} }
private: private:
const DeclContext *CurContext; const DeclContext *CurContext;
}; };
PrintCB PCB(&CurContext); PrintCB PCB(&CurContext);
PP.Callbacks = &PCB; PP.Callbacks = &PCB;
▲ Show 20 Lines • Show All 160 Lines • Show Last 20 Lines