The functions will be removed by January 20th.
All call sites within MLIR have been converted in previous changes.
Differential D94191
[mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated. csigg on Jan 6 2021, 1:02 PM. Authored by
Details The functions will be removed by January 20th. All call sites within MLIR have been converted in previous changes.
Diff Detail
Event Timeline
Comment Actions Hmm, I need to separate the definition for this to work. Will do so tomorrow, it's getting late. Comment Actions Separate definition because gcc 10 doesn't allow attributes on function definition. It's done now, but it seems to me that the C++14 attribute would have been cleaner. LLVM uses C++14, so I'm wondering if the LLVM_ATTRIBUTE_DEPRECATED macro itself should be deprecated ;-) Comment Actions I totally agree, but didn't want to deviate unless it is agreed in the community that we can just use deprecate now. Comment Actions I'm seeing a lot of deprecation warnings in our presubmit, will those be gone post the function removal today? Comment Actions I will take care of cleaning up the warnings before removing the actual functions, but it will probably be later this week. |