[mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated.

[csigg]

Summary

The functions will be removed by January 20th.

All call sites within MLIR have been converted in previous changes.

[rriddle]

mlir/include/mlir/IR/OpDefinition.h

108

Let's use LLVM_ATTRIBUTE_DEPRECATED instead of deprecated.

[rriddle]

Nice!

[csigg]

Use LLVM_ATTRIBUTE_DEPRECATED.

[csigg]

Hmm, I need to separate the definition for this to work. Will do so tomorrow, it's getting late.

[csigg]

Separate definition because gcc 10 doesn't allow attributes on function definition.

It's done now, but it seems to me that the C++14 attribute would have been cleaner.

LLVM uses C++14, so I'm wondering if the LLVM_ATTRIBUTE_DEPRECATED macro itself should be deprecated ;-)

[rriddle]

In D94191#2483685, @csigg wrote:

Separate definition because gcc 10 doesn't allow attributes on function definition.

It's done now, but it seems to me that the C++14 attribute would have been cleaner.

LLVM uses C++14, so I'm wondering if the LLVM_ATTRIBUTE_DEPRECATED macro itself should be deprecated ;-)

I totally agree, but didn't want to deviate unless it is agreed in the community that we can just use deprecate now.

[jpienaar]

I'm seeing a lot of deprecation warnings in our presubmit, will those be gone post the function removal today?

[csigg]

In D94191#2510375, @jpienaar wrote:

I'm seeing a lot of deprecation warnings in our presubmit, will those be gone post the function removal today?

I will take care of cleaning up the warnings before removing the actual functions, but it will probably be later this week.