Page MenuHomePhabricator

[mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated.
ClosedPublic

Authored by csigg on Jan 6 2021, 1:02 PM.

Details

Summary

The functions will be removed by January 20th.

All call sites within MLIR have been converted in previous changes.

Diff Detail

Event Timeline

csigg created this revision.Jan 6 2021, 1:02 PM
csigg requested review of this revision.Jan 6 2021, 1:02 PM
rriddle accepted this revision.Jan 6 2021, 1:04 PM
rriddle added inline comments.
mlir/include/mlir/IR/OpDefinition.h
108

Let's use LLVM_ATTRIBUTE_DEPRECATED instead of deprecated.

This revision is now accepted and ready to land.Jan 6 2021, 1:04 PM
csigg updated this revision to Diff 314973.Jan 6 2021, 1:23 PM

Use LLVM_ATTRIBUTE_DEPRECATED.

csigg added a comment.Jan 6 2021, 1:28 PM

Hmm, I need to separate the definition for this to work. Will do so tomorrow, it's getting late.

csigg updated this revision to Diff 315050.Jan 6 2021, 10:56 PM

Separate definition because gcc 10 doesn't allow attributes on function definition.

It's done now, but it seems to me that the C++14 attribute would have been cleaner.

LLVM uses C++14, so I'm wondering if the LLVM_ATTRIBUTE_DEPRECATED macro itself should be deprecated ;-)

Separate definition because gcc 10 doesn't allow attributes on function definition.

It's done now, but it seems to me that the C++14 attribute would have been cleaner.

LLVM uses C++14, so I'm wondering if the LLVM_ATTRIBUTE_DEPRECATED macro itself should be deprecated ;-)

I totally agree, but didn't want to deviate unless it is agreed in the community that we can just use deprecate now.

This revision was landed with ongoing or failed builds.Jan 7 2021, 12:08 AM
This revision was automatically updated to reflect the committed changes.

I'm seeing a lot of deprecation warnings in our presubmit, will those be gone post the function removal today?

I'm seeing a lot of deprecation warnings in our presubmit, will those be gone post the function removal today?

I will take care of cleaning up the warnings before removing the actual functions, but it will probably be later this week.