This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function
ClosedPublic

Authored by pdhaliwal on Jan 4 2021, 8:54 PM.

Details

Summary

AMDGPU backend requires entry functions/kernels to have AMDGPU_KERNEL
calling convention for proper linking.

Diff Detail

Event Timeline

pdhaliwal created this revision.Jan 4 2021, 8:54 PM
pdhaliwal requested review of this revision.Jan 4 2021, 8:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2021, 8:54 PM
JonChesterfield accepted this revision.Jan 5 2021, 3:11 AM

LGTM. This is the same hook hip & opencl use to indicate that a function is a kernel entry point. We may need to create the metadata openmp nvptx uses as well, but that's separate.

This revision is now accepted and ready to land.Jan 5 2021, 3:11 AM