This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix MathJax rendering in Affine doc
ClosedPublic

Authored by Lewuathe on Jan 3 2021, 10:33 PM.

Details

Summary

MathJax is not properly imported in Affine doc. It causes the invalid rendering
of math formulas in the Affine doc page.

https://mlir.llvm.org/docs/Dialects/Affine/#affine-expressions

Importing MathJax code from CDN resolved the rendering issue as follows.

Diff Detail

Event Timeline

Lewuathe created this revision.Jan 3 2021, 10:33 PM
Lewuathe requested review of this revision.Jan 3 2021, 10:33 PM
Lewuathe edited the summary of this revision. (Show Details)Jan 3 2021, 10:34 PM
Lewuathe edited the summary of this revision. (Show Details)
Lewuathe retitled this revision from Fix MathJax rendering in Affine doc to [mlir] Fix MathJax rendering in Affine doc.
Lewuathe edited the summary of this revision. (Show Details)Jan 3 2021, 10:37 PM
Lewuathe added reviewers: rriddle, ftynse.
jpienaar added inline comments.
mlir/docs/Dialects/Affine.md
1

This might make more sense in the Hugo template directly (in mlir-www repo) rather than have it in the markdown for the dialect.

Lewuathe added inline comments.Jan 4 2021, 3:10 PM
mlir/docs/Dialects/Affine.md
1

Thanks. Okay, I'll send a PR to the repository mlir-www.

Lewuathe updated this revision to Diff 314511.Jan 4 2021, 11:41 PM

Post review follow-up moving MathJax import to mlir-www

I have created a PR in the mlir-www repository to add MathJax.
https://github.com/llvm/mlir-www/pull/53

ftynse accepted this revision.Jan 5 2021, 2:35 AM

Thanks!

This revision is now accepted and ready to land.Jan 5 2021, 2:35 AM
Lewuathe added a comment.EditedJan 5 2021, 3:40 PM

@ftynse Thanks! Can I ask you to land this change in the repository on behalf of me? I do not have any write permission in the repository.

This revision was automatically updated to reflect the committed changes.