This is an archive of the discontinued LLVM Phabricator instance.

[mlir][python] Add FlatSymbolRef attribute.
ClosedPublic

Authored by stellaraccident on Dec 29 2020, 11:51 AM.

Diff Detail

Event Timeline

stellaraccident requested review of this revision.Dec 29 2020, 11:51 AM
mehdi_amini accepted this revision.Dec 29 2020, 11:58 AM

Can we add a simple smoke test?

mlir/lib/Bindings/Python/IRModules.cpp
1669
This revision is now accepted and ready to land.Dec 29 2020, 11:58 AM

Seems like your update crossed my comment, LG :)

stellaraccident marked an inline comment as done.Dec 29 2020, 12:04 PM

Seems like your update crossed my comment, LG :)

Ha, yes - I've been on vacation for a bit and when I sent this, I was like... wait, I think I'm missing something :)

Address comments.

This revision was landed with ongoing or failed builds.Dec 29 2020, 12:30 PM
This revision was automatically updated to reflect the committed changes.