This is an archive of the discontinued LLVM Phabricator instance.

Differential D93505

[OpenMP] Add definition/interface for target memory routines
ClosedPublic

Authored by hbae on Dec 17 2020, 5:55 PM.

Details

Reviewers
AndreyChurbanov
jlpeyton
jdoerfert
Commits
rG82a29a62aba5: [OpenMP] Add definition/interface for target memory routines
Summary

The change includes new routines introduced in 5.1 and Fortran interface.

Diff Detail

Event Timeline

hbae created this revision.Dec 17 2020, 5:55 PM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptDec 17 2020, 5:55 PM
hbae requested review of this revision.Dec 17 2020, 5:55 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptDec 17 2020, 5:55 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B82893: Diff 312657.Dec 17 2020, 6:26 PM
AndreyChurbanov accepted this revision.Dec 30 2020, 2:40 PM

LGTM

This revision is now accepted and ready to land.Dec 30 2020, 2:40 PM
Closed by commit rG82a29a62aba5: [OpenMP] Add definition/interface for target memory routines (authored by hbae). · Explain WhyJan 4 2021, 6:13 AM
This revision was automatically updated to reflect the committed changes.
hbae added a commit: rG82a29a62aba5: [OpenMP] Add definition/interface for target memory routines.
kkwli0 added a subscriber: kkwli0.Jan 4 2021, 7:05 AM
kkwli0 added inline comments.
openmp/runtime/src/include/omp_lib.h.var
593

Why not c_int? Will it be guaranteed that this will be interoperable with int?

hbae added inline comments.Jan 4 2021, 3:36 PM
openmp/runtime/src/include/omp_lib.h.var
593

Yes, it is safer to follow 5.1 specification.
I will upload a follow-up patch soon.

Revision Contents

PathSize
openmp/
runtime/
src/
include/
18 lines
107 lines
97 lines

Diff 314371

openmp/runtime/src/include/omp.h.var

Show First 20 Lines • Show All 207 Lines • ▼ Show 20 Lines# endif
* The `omp_get_interop_type_desc` routine retrieves a description of the type of a property associated with an `omp_interop_t` object. * The `omp_get_interop_type_desc` routine retrieves a description of the type of a property associated with an `omp_interop_t` object.
*/ */
extern const char * __KAI_KMPC_CONVENTION omp_get_interop_type_desc(const omp_interop_t, omp_interop_property_t); extern const char * __KAI_KMPC_CONVENTION omp_get_interop_type_desc(const omp_interop_t, omp_interop_property_t);
/*! /*!
* The `omp_get_interop_rc_desc` routine retrieves a description of the return code associated with an `omp_interop_t` object. * The `omp_get_interop_rc_desc` routine retrieves a description of the return code associated with an `omp_interop_t` object.
*/ */
extern const char * __KAI_KMPC_CONVENTION omp_get_interop_rc_desc(const omp_interop_rc_t, omp_interop_rc_t); extern const char * __KAI_KMPC_CONVENTION omp_get_interop_rc_desc(const omp_interop_rc_t, omp_interop_rc_t);
/* OpenMP 5.1 device memory routines */
/*!
* The `omp_target_memcpy_async` routine asynchronously performs a copy between any combination of host and device pointers.
*/
extern int __KAI_KMPC_CONVENTION omp_target_memcpy_async(void *, const void *, size_t, size_t, size_t, int,
int, int, omp_depend_t *);
/*!
* The `omp_target_memcpy_rect_async` routine asynchronously performs a copy between any combination of host and device pointers.
*/
extern int __KAI_KMPC_CONVENTION omp_target_memcpy_rect_async(void *, const void *, size_t, int, const size_t *,
const size_t *, const size_t *, const size_t *, const size_t *, int, int,
int, omp_depend_t *);
/*!
* The `omp_get_mapped_ptr` routine returns the device pointer that is associated with a host pointer for a given device.
*/
extern void * __KAI_KMPC_CONVENTION omp_get_mapped_ptr(const void *, int);
/* kmp API functions */ /* kmp API functions */
extern int __KAI_KMPC_CONVENTION kmp_get_stacksize (void); extern int __KAI_KMPC_CONVENTION kmp_get_stacksize (void);
extern void __KAI_KMPC_CONVENTION kmp_set_stacksize (int); extern void __KAI_KMPC_CONVENTION kmp_set_stacksize (int);
extern size_t __KAI_KMPC_CONVENTION kmp_get_stacksize_s (void); extern size_t __KAI_KMPC_CONVENTION kmp_get_stacksize_s (void);
extern void __KAI_KMPC_CONVENTION kmp_set_stacksize_s (size_t); extern void __KAI_KMPC_CONVENTION kmp_set_stacksize_s (size_t);
extern int __KAI_KMPC_CONVENTION kmp_get_blocktime (void); extern int __KAI_KMPC_CONVENTION kmp_get_blocktime (void);
extern int __KAI_KMPC_CONVENTION kmp_get_library (void); extern int __KAI_KMPC_CONVENTION kmp_get_library (void);
extern void __KAI_KMPC_CONVENTION kmp_set_blocktime (int); extern void __KAI_KMPC_CONVENTION kmp_set_blocktime (int);
▲ Show 20 Lines • Show All 219 Lines • Show Last 20 Lines

openmp/runtime/src/include/omp_lib.h.var

Show First 20 Lines • Show All 579 Lines • ▼ Show 20 Lines!DIR$ ENDIF
integer (kind=kmp_size_t_kind) :: omp_capture_affinity integer (kind=kmp_size_t_kind) :: omp_capture_affinity
end function omp_capture_affinity end function omp_capture_affinity
subroutine omp_display_env(verbose) bind(c) subroutine omp_display_env(verbose) bind(c)
import import
logical (kind=omp_logical_kind), value :: verbose logical (kind=omp_logical_kind), value :: verbose
end subroutine omp_display_env end subroutine omp_display_env
function omp_target_alloc(size, device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
type(c_ptr) omp_target_alloc
integer (kind=kmp_size_t_kind), value :: size
integer (kind=omp_integer_kind), value :: device_num
kkwli0Unsubmitted
Not Done
ReplyInline Actions

Why not c_int? Will it be guaranteed that this will be interoperable with int?

kkwli0: Why not `c_int`? Will it be guaranteed that this will be interoperable with `int`?
hbaeAuthorUnsubmitted
Done
ReplyInline Actions

Yes, it is safer to follow 5.1 specification.
I will upload a follow-up patch soon.

hbae: Yes, it is safer to follow 5.1 specification. I will upload a follow-up patch soon.
end function omp_target_alloc
subroutine omp_target_free(device_ptr, device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
type(c_ptr), value :: device_ptr
integer (kind=omp_integer_kind), value :: device_num
end subroutine omp_target_free
function omp_target_is_present(ptr, device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
integer (kind=omp_integer_kind) omp_target_is_present
type(c_ptr), value :: ptr
integer (kind=omp_integer_kind), value :: device_num
end function omp_target_is_present
function omp_target_memcpy(dst, src, length, dst_offset, &
& src_offset, dst_device_num, src_device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
integer (kind=omp_integer_kind) omp_target_memcpy
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: length, dst_offset, &
& src_offset
integer (kind=omp_integer_kind), value :: dst_device_num, &
& src_device_num
end function omp_target_memcpy
function omp_target_memcpy_rect(dst, src, element_size, &
& num_dims, volume, dst_offsets, src_offsets, dst_dimensions, &
& src_dimensions, dst_device_num, src_device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
integer (kind=omp_integer_kind) omp_target_memcpy_rect
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: element_size
integer (kind=omp_integer_kind), value :: num_dims, &
& dst_device_num, src_device_num
integer (kind=kmp_size_t_kind), intent(in) :: volume(*), &
& dst_offsets(*), src_offsets(*), dst_dimensions(*), &
& src_dimensions(*)
end function omp_target_memcpy_rect
function omp_target_memcpy_async(dst, src, length, dst_offset, &
& src_offset, dst_device_num, src_device_num, depobj_count, &
& depobj_list) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
integer (kind=omp_integer_kind) omp_target_memcpy_async
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: length, dst_offset, &
& src_offset
integer (kind=omp_integer_kind), value :: dst_device_num, &
& src_device_num, depobj_count
integer (kind=omp_depend_kind), optional :: depobj_list(*)
end function omp_target_memcpy_async
function omp_target_memcpy_rect_async(dst, src, element_size, &
& num_dims, volume, dst_offsets, src_offsets, dst_dimensions, &
& src_dimensions, dst_device_num, src_device_num, &
& depobj_count, depobj_list) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
integer (kind=omp_integer_kind) omp_target_memcpy_rect_async
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: element_size
integer (kind=omp_integer_kind), value :: num_dims, &
& dst_device_num, src_device_num, depobj_count
integer (kind=kmp_size_t_kind), intent(in) :: volume(*), &
& dst_offsets(*), src_offsets(*), dst_dimensions(*), &
& src_dimensions(*)
integer (kind=omp_depend_kind), optional :: depobj_list(*)
end function omp_target_memcpy_rect_async
function omp_target_associate_ptr(host_ptr, device_ptr, size, &
& device_offset, device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
integer (kind=omp_integer_kind) omp_target_associate_ptr
type(c_ptr), value :: host_ptr, device_ptr
integer (kind=kmp_size_t_kind), value :: size, device_offset
integer (kind=omp_integer_kind), value :: device_num
end function omp_target_associate_ptr
function omp_get_mapped_ptr(ptr, device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
type(c_ptr) omp_get_mapped_ptr
type(c_ptr), value :: ptr
integer (kind=omp_integer_kind), value :: device_num
end function omp_get_mapped_ptr
function omp_target_disassociate_ptr(ptr, device_num) bind(c)
use, intrinsic :: iso_c_binding, only : c_ptr
import
integer (kind=omp_integer_kind) omp_target_disassociate_ptr
type(c_ptr), value :: ptr
integer (kind=omp_integer_kind), value :: device_num
end function omp_target_disassociate_ptr
! *** ! ***
! *** kmp_* entry points ! *** kmp_* entry points
! *** ! ***
subroutine kmp_set_stacksize(size) bind(c) subroutine kmp_set_stacksize(size) bind(c)
import import
integer (kind=omp_integer_kind), value :: size integer (kind=omp_integer_kind), value :: size
end subroutine kmp_set_stacksize end subroutine kmp_set_stacksize
▲ Show 20 Lines • Show All 330 Lines • Show Last 20 Lines

openmp/runtime/src/include/omp_lib.f90.var

Show First 20 Lines • Show All 503 Lines • ▼ Show 20 Lines!DIR$ ENDIF
end function omp_capture_affinity end function omp_capture_affinity
subroutine omp_display_env(verbose) bind(c) subroutine omp_display_env(verbose) bind(c)
use omp_lib_kinds use omp_lib_kinds
logical (kind=omp_logical_kind), value :: verbose logical (kind=omp_logical_kind), value :: verbose
end subroutine omp_display_env end subroutine omp_display_env
function omp_target_alloc(size, device_num) bind(c)
use omp_lib_kinds
type(c_ptr) omp_target_alloc
integer (kind=kmp_size_t_kind), value :: size
integer (kind=omp_integer_kind), value :: device_num
end function omp_target_alloc
subroutine omp_target_free(device_ptr, device_num) bind(c)
use omp_lib_kinds
type(c_ptr), value :: device_ptr
integer (kind=omp_integer_kind), value :: device_num
end subroutine omp_target_free
function omp_target_is_present(ptr, device_num) bind(c)
use omp_lib_kinds
integer (kind=omp_integer_kind) omp_target_is_present
type(c_ptr), value :: ptr
integer (kind=omp_integer_kind), value :: device_num
end function omp_target_is_present
function omp_target_memcpy(dst, src, length, dst_offset, src_offset, &
dst_device_num, src_device_num) bind(c)
use omp_lib_kinds
integer (kind=omp_integer_kind) omp_target_memcpy
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: length, dst_offset, &
src_offset
integer (kind=omp_integer_kind), value :: dst_device_num, &
src_device_num
end function omp_target_memcpy
function omp_target_memcpy_rect(dst, src, element_size, num_dims, &
volume, dst_offsets, src_offsets, dst_dimensions, &
src_dimensions, dst_device_num, src_device_num) bind(c)
use omp_lib_kinds
integer (kind=omp_integer_kind) omp_target_memcpy_rect
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: element_size
integer (kind=omp_integer_kind), value :: num_dims, &
dst_device_num, src_device_num
integer (kind=kmp_size_t_kind), intent(in) :: volume(*), &
dst_offsets(*), src_offsets(*), dst_dimensions(*), &
src_dimensions(*)
end function omp_target_memcpy_rect
function omp_target_memcpy_async(dst, src, length, dst_offset, &
src_offset, dst_device_num, src_device_num, depobj_count, &
depobj_list) bind(c)
use omp_lib_kinds
integer (kind=omp_integer_kind) omp_target_memcpy_async
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: length, dst_offset, &
src_offset
integer (kind=omp_integer_kind), value :: dst_device_num, &
src_device_num, depobj_count
integer (kind=omp_depend_kind), optional :: depobj_list(*)
end function omp_target_memcpy_async
function omp_target_memcpy_rect_async(dst, src, element_size, &
num_dims, volume, dst_offsets, src_offsets, dst_dimensions, &
src_dimensions, dst_device_num, src_device_num, depobj_count, &
depobj_list) bind(c)
use omp_lib_kinds
integer (kind=omp_integer_kind) omp_target_memcpy_rect_async
type(c_ptr), value :: dst, src
integer (kind=kmp_size_t_kind), value :: element_size
integer (kind=omp_integer_kind), value :: num_dims, &
dst_device_num, src_device_num, depobj_count
integer (kind=kmp_size_t_kind), intent(in) :: volume(*), &
dst_offsets(*), src_offsets(*), dst_dimensions(*), &
src_dimensions(*)
integer (kind=omp_depend_kind), optional :: depobj_list(*)
end function omp_target_memcpy_rect_async
function omp_target_associate_ptr(host_ptr, device_ptr, size, &
device_offset, device_num) bind(c)
use omp_lib_kinds
integer (kind=omp_integer_kind) omp_target_associate_ptr
type(c_ptr), value :: host_ptr, device_ptr
integer (kind=kmp_size_t_kind), value :: size, device_offset
integer (kind=omp_integer_kind), value :: device_num
end function omp_target_associate_ptr
function omp_get_mapped_ptr(ptr, device_num) bind(c)
use omp_lib_kinds
type(c_ptr) omp_get_mapped_ptr
type(c_ptr), value :: ptr
integer (kind=omp_integer_kind), value :: device_num
end function omp_get_mapped_ptr
function omp_target_disassociate_ptr(ptr, device_num) bind(c)
use omp_lib_kinds
integer (kind=omp_integer_kind) omp_target_disassociate_ptr
type(c_ptr), value :: ptr
integer (kind=omp_integer_kind), value :: device_num
end function omp_target_disassociate_ptr
! *** ! ***
! *** kmp_* entry points ! *** kmp_* entry points
! *** ! ***
subroutine kmp_set_stacksize(size) bind(c) subroutine kmp_set_stacksize(size) bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind), value :: size integer (kind=omp_integer_kind), value :: size
end subroutine kmp_set_stacksize end subroutine kmp_set_stacksize
▲ Show 20 Lines • Show All 170 Lines • Show Last 20 Lines