Page MenuHomePhabricator

[mlir] NFC: retire LLVM_Zero/OneResultOp from LLVM dialect ODS
ClosedPublic

Authored by ftynse on Dec 15 2020, 12:11 PM.

Details

Summary

These classes were initially introduced to factor out two common parts of LLVM
op definitions: the fact that they have no results or a single result of
LLVM_Type, and the default builders. Neither of the two parts is really
common anymore: many ops have more specific on the result type, and many ops
provide custom builders. The TableGen classes only add conceptual complexity
and make LLVM dialect definition dissimilar to other dialects. Remove them in
favor of explicitly specified builders (results are already specified).

Depends On D93329

Diff Detail

Event Timeline

ftynse created this revision.Dec 15 2020, 12:11 PM
ftynse requested review of this revision.Dec 15 2020, 12:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2020, 12:11 PM
rriddle accepted this revision.Dec 15 2020, 12:11 PM
This revision is now accepted and ready to land.Dec 15 2020, 12:11 PM
This revision was landed with ongoing or failed builds.Dec 15 2020, 2:50 PM
This revision was automatically updated to reflect the committed changes.