This is an archive of the discontinued LLVM Phabricator instance.

Differential D93167

[NFC] Add CMakeUserPresets.json filename to .gitignore
ClosedPublic

Authored by steakhal on Dec 12 2020, 12:55 PM.

Details

Reviewers
echristo
jyknight
beanz
dblaikie
Commits
rGdef99ad68bce: [NFC] Add CMakeUserPresets.json filename to .gitignore
Summary

CMake 3.19 introduced the presets.
Quoting the documentation:

CMakePresets.json may be checked into a version control system, and CMakeUserPresets.json should NOT be checked in.

We will ignore the CMakeUserPresets.json file if that is present at the root of a subproject.

Diff Detail

Event Timeline

steakhal created this revision.Dec 12 2020, 12:55 PM
Herald added a subscriber: martong. · View Herald TranscriptDec 12 2020, 12:55 PM
steakhal requested review of this revision.Dec 12 2020, 12:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2020, 12:55 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
steakhal removed a reviewer: • stephenkelly.Dec 12 2020, 12:58 PM
steakhal added a subscriber: steveire.
steakhal added a reviewer: dblaikie.Jan 16 2021, 8:36 AM
dblaikie accepted this revision.Jan 17 2021, 10:51 AM

Sounds good, thanks!

This revision is now accepted and ready to land.Jan 17 2021, 10:51 AM
This revision was landed with ongoing or failed builds.Jan 22 2021, 3:46 AM
Closed by commit rGdef99ad68bce: [NFC] Add CMakeUserPresets.json filename to .gitignore (authored by steakhal). · Explain Why
This revision was automatically updated to reflect the committed changes.
steakhal added a commit: rGdef99ad68bce: [NFC] Add CMakeUserPresets.json filename to .gitignore.

Revision Contents

PathSize
3 lines

Diff 318479

.gitignore

Show All 15 Lines
# Byte compiled python modules. # Byte compiled python modules.
*.pyc *.pyc
# vim swap files # vim swap files
.*.sw? .*.sw?
.sw? .sw?
#OS X specific files. #OS X specific files.
.DS_store .DS_store
# Ignore the user specified CMake presets in subproject directories.
/*/CMakeUserPresets.json
# Nested build directory # Nested build directory
/build* /build*
#==============================================================================# #==============================================================================#
# Explicit files to ignore (only matches one). # Explicit files to ignore (only matches one).
#==============================================================================# #==============================================================================#
# Various tag programs # Various tag programs
/tags /tags
Show All 36 Lines