Don't emit info on op during reproducer error emission

[jpienaar]

Summary

This avoids dumping the module post emitting a reproducer, which results in
many MB logs where a reproducer has already been neatly generated and obscures
the error that led to the failure.

[mehdi_amini]

mlir/lib/Pass/Pass.cpp

776

You can remove both if and replace the true with shouldPrintOnOp here.

mlir/lib/Pass/Pass.cpp

recoveryContext.RunSafelyOnThread([&] {
     passManagerResult = success();
   });
   if (succeeded(passManagerResult))
     return success();
 
   std::string error;
   if (failed(context.generate(error)))
     return op->emitError("<MLIR-PassManager-Crash-Reproducer>: ") << error;
-  return op->emitError()
-         << "A failure has been detected while processing the MLIR module, a "
-            "reproducer has been generated in '"
-         << *crashReproducerFileName << "'";
+  bool shouldPrintOnOp = op->getContext()->shouldPrintOpOnDiagnostic();
+  if (shouldPrintOnOp)
+    op->getContext()->printOpOnDiagnostic(false);
+  op->emitError()
+  if (shouldPrintOnOp)
+    op->getContext()->printOpOnDiagnostic(true);
+  return failure();
 }
 
 //===----------------------------------------------------------------------===//
 // PassManager
 //===----------------------------------------------------------------------===//
 
 PassManager::PassManager(MLIRContext *ctx, Nesting nesting,
                          StringRef operationName)