This is an archive of the discontinued LLVM Phabricator instance.

Don't emit info on op during reproducer error emission
ClosedPublic

Authored by jpienaar on Dec 12 2020, 10:34 AM.

Details

Summary

This avoids dumping the module post emitting a reproducer, which results in
many MB logs where a reproducer has already been neatly generated and obscures
the error that led to the failure.

Diff Detail

Event Timeline

jpienaar created this revision.Dec 12 2020, 10:34 AM
jpienaar requested review of this revision.Dec 12 2020, 10:34 AM
mehdi_amini accepted this revision.Dec 12 2020, 7:01 PM
mehdi_amini added inline comments.
mlir/lib/Pass/Pass.cpp
776

You can remove both if and replace the true with shouldPrintOnOp here.

This revision is now accepted and ready to land.Dec 12 2020, 7:01 PM
This revision was landed with ongoing or failed builds.Dec 13 2020, 7:21 AM
This revision was automatically updated to reflect the committed changes.
jpienaar marked an inline comment as done.