[clang][cli] Revert accidental access-control flag rename

[jansvoboda11]

Summary

This commit https://reviews.llvm.org/rGe5158b52730d323bb8cd2cba6dc6c89b90cba452 introduced an accidental change, which renames -faccess-control and -fno-access-control to -fno-access-control and -fno-no-access-control.

[dexonsmith]

LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later.

[dexonsmith]

In D93104#2449783, @dexonsmith wrote:

LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later.

(It'd be nice to have a test for this too if possible...)

[dexonsmith]

In D93104#2449787, @dexonsmith wrote:

In D93104#2449783, @dexonsmith wrote:

LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later.

Ah, I see the original commit was a while ago, so maybe not so time-sensitive.

(It'd be nice to have a test for this too if possible...)

(Or maybe OptOutFFLag could reject an option beginning with "no-"?)

[MaskRay]

Thanks! Sorry for the breakage.

Actually, neither -fno-access-control nor -faccess-control has any test..

[jansvoboda11]

(Or maybe OptOutFFLag could reject an option beginning with "no-"?)

I think this is reasonable. I'll reach out to the mailing list to see if there's a way to add assertions to TableGen that would catch this.

Thanks! Sorry for the breakage.

No problem.

clang/include/clang/Driver/Options.td

 def exported__symbols__list : Separate<["-"], "exported_symbols_list">;
 def e : JoinedOrSeparate<["-"], "e">, Flags<[LinkerInput]>, Group<Link_Group>;
 def fmax_tokens_EQ : Joined<["-"], "fmax-tokens=">, Group<f_Group>, Flags<[CC1Option]>,
   HelpText<"Max total number of preprocessed tokens for -Wmax-tokens.">;
 def fPIC : Flag<["-"], "fPIC">, Group<f_Group>;
 def fno_PIC : Flag<["-"], "fno-PIC">, Group<f_Group>;
 def fPIE : Flag<["-"], "fPIE">, Group<f_Group>;
 def fno_PIE : Flag<["-"], "fno-PIE">, Group<f_Group>;
-defm access_control : OptOutFFlag<"no-access-control", "", "Disable C++ access control">;
+defm access_control : OptOutFFlag<"access-control", "", "Disable C++ access control">;
 def falign_functions : Flag<["-"], "falign-functions">, Group<f_Group>;
 def falign_functions_EQ : Joined<["-"], "falign-functions=">, Group<f_Group>;
 def fno_align_functions: Flag<["-"], "fno-align-functions">, Group<f_Group>;
 defm allow_editor_placeholders : OptInFFlag<"allow-editor-placeholders", "Treat editor placeholders as valid source code">;
 def fallow_unsupported : Flag<["-"], "fallow-unsupported">, Group<f_Group>;
 def fapple_kext : Flag<["-"], "fapple-kext">, Group<f_Group>, Flags<[CC1Option]>,
   HelpText<"Use Apple's kernel extensions ABI">;
 def fapple_pragma_pack : Flag<["-"], "fapple-pragma-pack">, Group<f_Group>, Flags<[CC1Option]>,