This is an archive of the discontinued LLVM Phabricator instance.

[clang][cli] Revert accidental access-control flag rename
ClosedPublic

Authored by jansvoboda11 on Dec 11 2020, 4:20 AM.

Details

Summary

This commit https://reviews.llvm.org/rGe5158b52730d323bb8cd2cba6dc6c89b90cba452 introduced an accidental change, which renames -faccess-control and -fno-access-control to -fno-access-control and -fno-no-access-control.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Dec 11 2020, 4:20 AM
jansvoboda11 requested review of this revision.Dec 11 2020, 4:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2020, 4:20 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dexonsmith accepted this revision.Dec 11 2020, 2:39 PM

LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later.

This revision is now accepted and ready to land.Dec 11 2020, 2:39 PM

LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later.

(It'd be nice to have a test for this too if possible...)

LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later.

Ah, I see the original commit was a while ago, so maybe not so time-sensitive.

(It'd be nice to have a test for this too if possible...)

(Or maybe OptOutFFLag could reject an option beginning with "no-"?)

MaskRay accepted this revision.Dec 11 2020, 3:22 PM

Thanks! Sorry for the breakage.

Actually, neither -fno-access-control nor -faccess-control has any test..

(Or maybe OptOutFFLag could reject an option beginning with "no-"?)

I think this is reasonable. I'll reach out to the mailing list to see if there's a way to add assertions to TableGen that would catch this.

Thanks! Sorry for the breakage.

No problem.

This revision was landed with ongoing or failed builds.Dec 12 2020, 2:52 AM
This revision was automatically updated to reflect the committed changes.