This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess
ClosedPublic

Authored by MyDeveloperDay on Dec 9 2020, 2:06 AM.

Details

Summary

clang-format see the disable: in __pragma(warning(disable:)) as ObjectiveC method call

Remove any line starting with # or __pragma line from being part of the ObjectiveC guess

https://bugs.llvm.org/show_bug.cgi?id=42434

Diff Detail

Event Timeline

MyDeveloperDay requested review of this revision.Dec 9 2020, 2:06 AM
MyDeveloperDay created this revision.
curdeius edited the summary of this revision. (Show Details)Dec 9 2020, 4:35 AM
curdeius added inline comments.
clang/lib/Format/Format.cpp
2037
curdeius requested changes to this revision.Dec 9 2020, 4:37 AM
This revision now requires changes to proceed.Dec 9 2020, 4:37 AM

add support for additional _Pragma

MyDeveloperDay marked an inline comment as done.Dec 9 2020, 7:12 AM
krasimir accepted this revision.Dec 9 2020, 7:21 AM

This is very nice :)

curdeius accepted this revision.Dec 9 2020, 8:08 AM

Great! LGTM.

This revision is now accepted and ready to land.Dec 9 2020, 8:08 AM