Page MenuHomePhabricator

JakeMerdichAMD (Jake Merdich)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 1 2020, 6:09 AM (22 w, 5 d)

Recent Activity

Mon, Jun 29

JakeMerdichAMD committed rG0c332a7784c6: [clang-format] Preserve whitespace in selected macros (authored by JakeMerdichAMD).
[clang-format] Preserve whitespace in selected macros
Mon, Jun 29, 7:01 AM
JakeMerdichAMD closed D82620: [clang-format] Preserve whitespace in selected macros.
Mon, Jun 29, 7:01 AM · Restricted Project, Restricted Project

Fri, Jun 26

JakeMerdichAMD added a comment to D82620: [clang-format] Preserve whitespace in selected macros.

Thanks for the fast review, @curdeius, and thanks for mentioning PP_STRINGIZE and BOOST_PP_STRINGIZE too!

Fri, Jun 26, 7:37 AM · Restricted Project, Restricted Project
JakeMerdichAMD updated the diff for D82620: [clang-format] Preserve whitespace in selected macros.

Address feedback (nits, better docs, more defaults)

Fri, Jun 26, 7:37 AM · Restricted Project, Restricted Project
JakeMerdichAMD added inline comments to D82620: [clang-format] Preserve whitespace in selected macros.
Fri, Jun 26, 7:05 AM · Restricted Project, Restricted Project

Thu, Jun 25

JakeMerdichAMD added reviewers for D82620: [clang-format] Preserve whitespace in selected macros: MyDeveloperDay, curdeius, sammccall, jbcoe.
Thu, Jun 25, 7:40 PM · Restricted Project, Restricted Project
JakeMerdichAMD created D82620: [clang-format] Preserve whitespace in selected macros.
Thu, Jun 25, 7:40 PM · Restricted Project, Restricted Project

May 28 2020

JakeMerdichAMD added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

Great idea on this! I may borrow this idea and make something similar for some migrations I'm working on.

May 28 2020, 9:49 AM · Restricted Project, Restricted Project

May 25 2020

JakeMerdichAMD created D80528: [clang-format][WIP] Run more stability FormatTests.
May 25 2020, 11:46 AM · Restricted Project, Restricted Project
JakeMerdichAMD added a project to D80528: [clang-format][WIP] Run more stability FormatTests: Restricted Project.
May 25 2020, 11:46 AM · Restricted Project, Restricted Project

May 24 2020

JakeMerdichAMD committed rG52b03aaa22f6: [clang-format][PR46043] Parse git config w/ implicit values (authored by JakeMerdichAMD).
[clang-format][PR46043] Parse git config w/ implicit values
May 24 2020, 6:07 PM
JakeMerdichAMD closed D80486: [clang-format][PR46043] Parse git config w/ implicit values.
May 24 2020, 6:07 PM · Restricted Project

May 23 2020

JakeMerdichAMD created D80486: [clang-format][PR46043] Parse git config w/ implicit values.
May 23 2020, 7:38 PM · Restricted Project

May 22 2020

JakeMerdichAMD added a comment to D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions.

I'm a fan of the 'like' helpers, but I'm not entirely convinced that having helpers for languages covered by the 'like' is a bad thing-- it just needs to be very explicit that you do mean only that language. For example, an 'isObjCOnly()' would hint to reviewers that ObjC is sometimes used in combination with other languages and there may be a more appropriate helper (of course, this should be clearly documented as well).

May 22 2020, 7:28 AM · Restricted Project, Restricted Project

May 20 2020

JakeMerdichAMD committed rG51dbda543848: [clang-format][docfix] Update predefined styles in docs (authored by JakeMerdichAMD).
[clang-format][docfix] Update predefined styles in docs
May 20 2020, 5:09 PM
JakeMerdichAMD closed D80309: [clang-format][docfix] Update predefined styles in docs.
May 20 2020, 5:07 PM · Restricted Project, Restricted Project
JakeMerdichAMD accepted D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults.

LGTM

May 20 2020, 1:43 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults.

Just belatedly caught something: Webkit style is supported too but not listed here. Can you add that?

May 20 2020, 9:48 AM · Restricted Project, Restricted Project
JakeMerdichAMD added reviewers for D80309: [clang-format][docfix] Update predefined styles in docs: MyDeveloperDay, krasimir, mitchell-stellar, sammccall.
May 20 2020, 9:48 AM · Restricted Project, Restricted Project
JakeMerdichAMD created D80309: [clang-format][docfix] Update predefined styles in docs.
May 20 2020, 9:48 AM · Restricted Project, Restricted Project

May 19 2020

JakeMerdichAMD added a comment to D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults.

+1 for this idea. It'd eventually be neat to also take all samples from the style guide of each project and test them, if there aren't licensing concerns.

May 19 2020, 4:00 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D79465: [clang-format] Fix line lengths w/ comments in align.

Hey @MyDeveloperDay, can I get your assistance committing this when you have the chance?

May 19 2020, 3:59 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields.

Can I get your assistance committing this?

May 19 2020, 3:29 PM · Restricted Project, Restricted Project
JakeMerdichAMD accepted D80228: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension.
May 19 2020, 2:55 PM · Restricted Project, Restricted Project
JakeMerdichAMD updated the diff for D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields.

Reformat with a newer clang-format

May 19 2020, 2:53 PM · Restricted Project, Restricted Project
JakeMerdichAMD accepted D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format.

LGTM assuming CI tests pass.

May 19 2020, 6:28 AM · Restricted Project, Restricted Project

May 18 2020

JakeMerdichAMD updated the summary of D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields.
May 18 2020, 9:40 PM · Restricted Project, Restricted Project
JakeMerdichAMD updated the summary of D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields.
May 18 2020, 9:40 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields.

See follow-up in D80176.

May 18 2020, 9:40 PM · Restricted Project, Restricted Project
JakeMerdichAMD added reviewers for D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields: MyDeveloperDay, krasimir, mitchell-stellar, curdeius, owenpan.
May 18 2020, 9:09 PM · Restricted Project, Restricted Project
JakeMerdichAMD created D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields.
May 18 2020, 9:08 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format.

This is a great improvement in readability. I think this will get in here before it does for clang proper :D

May 18 2020, 5:22 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D80041: [clang-format] [PR45198] deletes whitespace inside of a noexcept specifier.

I mainly have concerns with the search for noexcept being too brittle and not looking far enough back. Implementing that may have performance implications though, so I have no issue ignoring that problem if it's proven sufficiently rare.

May 18 2020, 10:47 AM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields.

Good idea, feel free to incorporate anything about the change (eg, tests and TT_BitFieldColon) or delegate to me if you like.

May 18 2020, 8:34 AM · Restricted Project, Restricted Project
JakeMerdichAMD accepted D79905: [clang-format] [PR44476] Add space between template and attribute.

LGTM

May 18 2020, 8:01 AM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields.

Ironically, I independently made a near-identical change because my codebase needs this, and was going to upload it today. I won't post it now, but I stuck a copy on github if you're interested: https://github.com/JakeMerdichAMD/llvm-project/commit/6eec9ce0bb7732a519b765659422b72a9fa8aa67. I also have some more tests there, and will cross-check with this once the merge conflicts are fixed.

May 18 2020, 7:29 AM · Restricted Project, Restricted Project

May 15 2020

JakeMerdichAMD updated the diff for D79465: [clang-format] Fix line lengths w/ comments in align.

Rebase to fix merge conflict

May 15 2020, 11:25 AM · Restricted Project, Restricted Project
JakeMerdichAMD updated the diff for D79465: [clang-format] Fix line lengths w/ comments in align.

Add a comment explaining why checking IsInsideToken is needed here.

May 15 2020, 9:12 AM · Restricted Project, Restricted Project

May 13 2020

JakeMerdichAMD added a comment to D79905: [clang-format] [PR44476] Add space between template and attribute.

One spelling nit, but otherwise looks good to me.

May 13 2020, 2:09 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

Thanks for the commit and review @MyDeveloperDay!

May 13 2020, 11:25 AM · Restricted Project, Restricted Project

May 11 2020

JakeMerdichAMD added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

Hey, @MyDeveloperDay, can I get your assistance in committing this? It's probably been long enough for anyone to chime in.

May 11 2020, 7:29 AM · Restricted Project, Restricted Project

May 6 2020

JakeMerdichAMD added a comment to D79465: [clang-format] Fix line lengths w/ comments in align.

Mind looking again? They did add one later on I think. It helped a lot since the exact settings and whitespace to trigger this are really finicky (though reproducible). You're right that it won't reproduce without it.

May 6 2020, 8:02 AM · Restricted Project, Restricted Project

May 5 2020

JakeMerdichAMD created D79465: [clang-format] Fix line lengths w/ comments in align.
May 5 2020, 6:54 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a project to D79465: [clang-format] Fix line lengths w/ comments in align: Restricted Project.

The failing case in this commit looks like the following after formatting (with alignconsecutiveassignments and a specific column limit)

May 5 2020, 6:54 PM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

Sure, I'll get started on that. It mainly comes from charging headfirst into the edge cases, but I think I have a decent grasp of clang-format internals now, and I'm definitely interested in both contributing to and reviewing for it.

May 5 2020, 6:59 AM · Restricted Project, Restricted Project
JakeMerdichAMD added a project to D79388: [clang-format] Fix AlignConsecutive on PP blocks: Restricted Project.
May 5 2020, 6:58 AM · Restricted Project, Restricted Project
JakeMerdichAMD added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

@MyDeveloperDay, you're right about what this issue addresses: it surprised me a lot when an unrelated edit caused something to 'randomly' add spaces elsewhere, since it's in a different ifdef block (whether or not it has the same condition). The code that's aligned should always be across lines that are visually consecutive, and those ones weren't (in most cases, they aren't even logically consecutive).

May 5 2020, 4:48 AM · Restricted Project, Restricted Project

May 4 2020

JakeMerdichAMD added reviewers for D79388: [clang-format] Fix AlignConsecutive on PP blocks: MyDeveloperDay, krasimir.
May 4 2020, 7:57 PM · Restricted Project, Restricted Project
JakeMerdichAMD created D79388: [clang-format] Fix AlignConsecutive on PP blocks.
May 4 2020, 7:55 PM · Restricted Project, Restricted Project