[mlir][vector] rephrased description

[aartbik]

Summary

More carefully worded description. Added constructor to options.

[aartbik]

typo

[nicolasvasilache]

mlir/include/mlir/Conversion/VectorToLLVM/ConvertVectorToLLVM.h

31

Please don't remove this, this is how we chain options and is the pattern used pretty much everywhere.

[aartbik]

mlir/include/mlir/Conversion/VectorToLLVM/ConvertVectorToLLVM.h

31

Ok, moved them back. Also, I can't really name them without the "set" as was requested in previous review, since the names cannot be identical. So just keeping the "set" part.

[aartbik]

addressed comments

mlir/include/mlir/Conversion/Passes.td

 
 def ConvertVectorToLLVM : Pass<"convert-vector-to-llvm", "ModuleOp"> {
   let summary = "Lower the operations from the vector dialect into the LLVM "
                 "dialect";
   let description = [{
 
     Convert operations from the vector dialect into the LLVM IR dialect
     operations. The lowering pass provides several options to control
-    the kind of optimizations that are allowed. It also provides options
-    that augment the architectural-neutral vector dialect with
-    architectural-specific dialects (AVX512, Neon, etc.).
+    the kinds of optimizations that are allowed. It also provides options
+    that enable the use of one or more architectural-specific dialects
+    (AVX512, Neon, SVE, etc.) in combination with the architectural-neutral
+    vector dialect lowering.
 
   }];
   let constructor = "mlir::createConvertVectorToLLVMPass()";
   let dependentDialects = ["LLVM::LLVMDialect", "LLVM::LLVMAVX512Dialect"];
   let options = [
     Option<"reassociateFPReductions", "reassociate-fp-reductions",
            "bool", /*default=*/"false",
            "Allows llvm to reassociate floating-point reductions for speed">,
     Option<"enableIndexOptimizations", "enable-index-optimizations",
            "bool", /*default=*/"true",
            "Allows compiler to assume indices fit in 32-bit if that yields "
      "faster code">,
     Option<"enableAVX512", "enable-avx512",
            "bool", /*default=*/"false",
-           "Augments the vector dialect with the AVX512 dialect during lowering">
+           "Enables the use of AVX512 dialect while lowering the vector "
+     "dialect.">
   ];
 }
 
 //===----------------------------------------------------------------------===//
 // VectorToROCDL
 //===----------------------------------------------------------------------===//
 
 def ConvertVectorToROCDL : Pass<"convert-vector-to-rocdl", "ModuleOp"> {

mlir/include/mlir/Conversion/VectorToLLVM/ConvertVectorToLLVM.h

 template <typename T>
 class OperationPass;
 
 /// Options to control Vector to LLVM lowering.
 ///
 /// This should kept in sync with VectorToLLVM options defined for the
 /// ConvertVectorToLLVM pass in include/mlir/Conversion/Passes.td
 struct LowerVectorToLLVMOptions {
-  bool reassociateFPReductions = false;
-  bool enableIndexOptimizations = true;
-  bool enableAVX512 = false;
-  LowerVectorToLLVMOptions &setReassociateFPReductions(bool b) {
-    reassociateFPReductions = b;
-    return *this;
-  }
-  LowerVectorToLLVMOptions &setEnableIndexOptimizations(bool b) {
-    enableIndexOptimizations = b;
-    return *this;
-  }
-  LowerVectorToLLVMOptions &setEnableAVX512(bool b) {
-    enableAVX512 = b;
-    return *this;
-  }
+  LowerVectorToLLVMOptions()
+      : reassociateFPReductions(false), enableIndexOptimizations(true),
+        enableAVX512(false) {}
+  bool reassociateFPReductions;
+  bool enableIndexOptimizations;
+  bool enableAVX512;
 };
 
 /// Collect a set of patterns to convert from Vector contractions to LLVM Matrix
 /// Intrinsics. To lower to assembly, the LLVM flag -lower-matrix-intrinsics
 /// will be needed when invoking LLVM.
 void populateVectorToLLVMMatrixConversionPatterns(
     LLVMTypeConverter &converter, OwningRewritePatternList &patterns);