Page MenuHomePhabricator

[libc++] Add a CI job to test libc++ when building for 32 bit
ClosedPublic

Authored by ldionne on Dec 2 2020, 1:41 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGae4dad2b731e: [libc++] Add a CI job to test libc++ when building for 32 bit

Diff Detail

Unit TestsFailed

TimeTest
18,260 mslibcxx CI Apple back-deployment macosx10.15 > libc++.libcxx/modules::stds_include.sh.cpp
Script: -- : 'RUN: at line 29'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -v --target=x86_64-apple-macosx10.15 -include /tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.15/include/c++/v1 -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.15/projects/libcxx/include/c++build -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/private/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.15/projects/libcxx/test/libcxx/modules/Output/stds_include.sh.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -fmodules -fcxx-modules -fsyntax-only -std=c++03 -DINVALIDATE_CACHE_CXX03 /private/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/libcxx/modules/stds_include.sh.cpp
18,380 mslibcxx CI Apple back-deployment macosx10.9 > libc++.libcxx/modules::stds_include.sh.cpp
Script: -- : 'RUN: at line 29'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -v --target=x86_64-apple-macosx10.9 -include /tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.9/include/c++/v1 -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.9/projects/libcxx/include/c++build -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/private/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.9/projects/libcxx/test/libcxx/modules/Output/stds_include.sh.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -fmodules -fcxx-modules -fsyntax-only -std=c++03 -DINVALIDATE_CACHE_CXX03 /private/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/libcxx/modules/stds_include.sh.cpp
18,020 mslibcxx CI Apple system > libc++.libcxx/modules::stds_include.sh.cpp
Script: -- : 'RUN: at line 29'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -v --target=x86_64-apple-darwin19.6.0 -include /tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system/include/c++/v1 -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system/projects/libcxx/include/c++build -I/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/private/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system/projects/libcxx/test/libcxx/modules/Output/stds_include.sh.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -fmodules -fcxx-modules -fsyntax-only -std=c++03 -DINVALIDATE_CACHE_CXX03 /private/tmp/buildkite-builds/Granger-local-1/llvm-project/libcxx-ci/libcxx/test/libcxx/modules/stds_include.sh.cpp
19,330 mslibcxx CI Apple system -fno-exceptions > libc++.libcxx/modules::stds_include.sh.cpp
Script: -- : 'RUN: at line 29'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -v --target=x86_64-apple-darwin19.6.0 -include /tmp/buildkite-builds/Weasley-local-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/tmp/buildkite-builds/Weasley-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-noexceptions/include/c++/v1 -I/tmp/buildkite-builds/Weasley-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-noexceptions/projects/libcxx/include/c++build -I/tmp/buildkite-builds/Weasley-local-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -fno-exceptions -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/private/tmp/buildkite-builds/Weasley-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-noexceptions/projects/libcxx/test/libcxx/modules/Output/stds_include.sh.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -fmodules -fcxx-modules -fsyntax-only -std=c++03 -DINVALIDATE_CACHE_CXX03 /private/tmp/buildkite-builds/Weasley-local-1/llvm-project/libcxx-ci/libcxx/test/libcxx/modules/stds_include.sh.cpp
630 mslibcxx CI GCC-next/C++20 > libc++.std/atomics/atomics_types_operations/atomics_types_operations_req::atomic_is_lock_free.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/g++-11 /home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_is_lock_free.pass.cpp -v -include /home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/build/generic-gcc-next/include/c++/v1 -I/home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/build/generic-gcc-next/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-aligned-allocation-unavailable -Wno-atomic-alignment -Wno-sized-deallocation -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -lc++experimental -L/home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/build/generic-gcc-next/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/build/generic-gcc-next/./lib -L/home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/build/generic-gcc-next/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/build/generic-gcc-next/./lib -nodefaultlibs -lc++ -lm -lgcc_s -lgcc -lpthread -lc -lgcc_s -lgcc -latomic -o /home/libcxx-builder/.buildkite-agent/builds/a30afb7efc09-1/llvm-project/libcxx-ci/build/generic-gcc-next/projects/libcxx/test/std/atomics/atomics.types.
View Full Test Results (16 Failed)

Event Timeline

ldionne created this revision.Dec 2 2020, 1:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 1:41 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Dec 2 2020, 1:41 PM
ldionne updated this revision to Diff 309259.Dec 3 2020, 7:47 AM

Rebase to trigger CI again. The docker images should be updated and CI should pass now.

I suppose that these 2 tests were always failing on 32-bit.
The old builder history doesn't go very far, but it shows these tests always failing: http://lab.llvm.org:8011/#/builders/34?numbuilds=300.
Not sure if it was intended or not, but it seems that trivial_abi is only tested on arm64-apple-ios11 triple.
Cf. D41039.

FYI, https://bugs.llvm.org/show_bug.cgi?id=48939.
I think these two failing tests should be disabled on 32-bit x86.
I'm pretty sure for weak_ptr_ret.pass.cpp, cf.:

#ifndef __arm__
  // On ARM32, structs larger than 4 bytes cannot be returned in registers.
  // Thus, weak_ptr will be passed indrectly even if it is trivial.
  assert((void*)&ret != local_addr);
#endif

Not sure for unique_ptr_ret.pass.cpp though.

ldionne updated this revision to Diff 348823.May 31 2021, 9:32 AM

Rebase onto main - I think the underlying issues should have been fixed now.

ldionne updated this revision to Diff 348825.May 31 2021, 9:37 AM

Rebase onto main with the underlying issue fixed for real.

ldionne updated this revision to Diff 349091.Jun 1 2021, 1:37 PM

Poke CI.

ldionne accepted this revision as: Restricted Project.Jun 1 2021, 7:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 1 2021, 7:07 PM
This revision was automatically updated to reflect the committed changes.