Page MenuHomePhabricator

[libc++] Add a CI job to test libc++ when building for 32 bit
ClosedPublic

Authored by ldionne on Dec 2 2020, 1:41 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGae4dad2b731e: [libc++] Add a CI job to test libc++ when building for 32 bit

Diff Detail

Unit TestsFailed

TimeTest
900 mslibcxx CI 32 bit > libc++.libcxx/memory/trivial_abi::unique_ptr_ret.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp -m32 -v --target=x86_64-unknown-linux-gnu -include /home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/projects/libcxx/__config_site -include /home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/include -I/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/projects/libcxx/test/libcxx/memory/trivial_abi/Output/unique_ptr_ret.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI -L/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/./lib -nodefaultlibs -lc++ -lm -lgcc_s -lgcc -lpthread -lc -lgcc_s -lgcc -latomic…
970 mslibcxx CI 32 bit > libc++.libcxx/memory/trivial_abi::weak_ptr_ret.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/test/libcxx/memory/trivial_abi/weak_ptr_ret.pass.cpp -m32 -v --target=x86_64-unknown-linux-gnu -include /home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/projects/libcxx/__config_site -include /home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/include -I/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/projects/libcxx/test/libcxx/memory/trivial_abi/Output/weak_ptr_ret.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -D_LIBCPP_ABI_ENABLE_SHARED_PTR_TRIVIAL_ABI -L/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/2f27ca979489-1/llvm-project/libcxx-ci/build/generic-32bit/./lib -nodefaultlibs -lc++ -lm -lgcc_s -lgcc -lpthread -lc -lgcc_s -lgcc -latomic…

Event Timeline

ldionne created this revision.Dec 2 2020, 1:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 1:41 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Dec 2 2020, 1:41 PM
ldionne updated this revision to Diff 309259.Dec 3 2020, 7:47 AM

Rebase to trigger CI again. The docker images should be updated and CI should pass now.

I suppose that these 2 tests were always failing on 32-bit.
The old builder history doesn't go very far, but it shows these tests always failing: http://lab.llvm.org:8011/#/builders/34?numbuilds=300.
Not sure if it was intended or not, but it seems that trivial_abi is only tested on arm64-apple-ios11 triple.
Cf. D41039.

FYI, https://bugs.llvm.org/show_bug.cgi?id=48939.
I think these two failing tests should be disabled on 32-bit x86.
I'm pretty sure for weak_ptr_ret.pass.cpp, cf.:

#ifndef __arm__
  // On ARM32, structs larger than 4 bytes cannot be returned in registers.
  // Thus, weak_ptr will be passed indrectly even if it is trivial.
  assert((void*)&ret != local_addr);
#endif

Not sure for unique_ptr_ret.pass.cpp though.

ldionne updated this revision to Diff 348823.May 31 2021, 9:32 AM

Rebase onto main - I think the underlying issues should have been fixed now.

ldionne updated this revision to Diff 348825.May 31 2021, 9:37 AM

Rebase onto main with the underlying issue fixed for real.

ldionne updated this revision to Diff 349091.Jun 1 2021, 1:37 PM

Poke CI.

ldionne accepted this revision as: Restricted Project.Jun 1 2021, 7:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 1 2021, 7:07 PM
This revision was automatically updated to reflect the committed changes.