This is an archive of the discontinued LLVM Phabricator instance.

Differential D92482

[IR] Support scalable vectors in CastInst::CreatePointerCast
ClosedPublic

Authored by c-rhodes on Dec 2 2020, 7:02 AM.

Details

Reviewers
sdesmalen
RKSimon
efriedma
Commits
rG4167a0259ec3: [IR] Support scalable vectors in CastInst::CreatePointerCast

Diff Detail

Event Timeline

c-rhodes created this revision.Dec 2 2020, 7:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 7:02 AM
Herald added subscribers: dexonsmith, hiraditya. · View Herald Transcript
c-rhodes requested review of this revision.Dec 2 2020, 7:02 AM
Harbormaster completed remote builds in B80808: Diff 308956.Dec 2 2020, 7:26 AM
sdesmalen accepted this revision.Dec 8 2020, 8:14 AM

LGTM!

This revision is now accepted and ready to land.Dec 8 2020, 8:14 AM
This revision was landed with ongoing or failed builds.Dec 9 2020, 3:01 AM
Closed by commit rG4167a0259ec3: [IR] Support scalable vectors in CastInst::CreatePointerCast (authored by c-rhodes). · Explain Why
This revision was automatically updated to reflect the committed changes.
c-rhodes added a commit: rG4167a0259ec3: [IR] Support scalable vectors in CastInst::CreatePointerCast.

Revision Contents

PathSize
llvm/
lib/
IR/
8 lines
unittests/
IR/
8 lines

Diff 308956

llvm/lib/IR/Instructions.cpp

Show First 20 Lines • Show All 3,016 Lines • ▼ Show 20 Lines
CastInst *CastInst::CreatePointerCast(Value *S, Type *Ty, CastInst *CastInst::CreatePointerCast(Value *S, Type *Ty,
const Twine &Name, const Twine &Name,
BasicBlock *InsertAtEnd) { BasicBlock *InsertAtEnd) {
assert(S->getType()->isPtrOrPtrVectorTy() && "Invalid cast"); assert(S->getType()->isPtrOrPtrVectorTy() && "Invalid cast");
assert((Ty->isIntOrIntVectorTy() || Ty->isPtrOrPtrVectorTy()) && assert((Ty->isIntOrIntVectorTy() || Ty->isPtrOrPtrVectorTy()) &&
"Invalid cast"); "Invalid cast");
assert(Ty->isVectorTy() == S->getType()->isVectorTy() && "Invalid cast"); assert(Ty->isVectorTy() == S->getType()->isVectorTy() && "Invalid cast");
assert((!Ty->isVectorTy() || assert((!Ty->isVectorTy() ||
cast<FixedVectorType>(Ty)->getNumElements() == cast<VectorType>(Ty)->getElementCount() ==
cast<FixedVectorType>(S->getType())->getNumElements()) && cast<VectorType>(S->getType())->getElementCount()) &&
"Invalid cast"); "Invalid cast");
if (Ty->isIntOrIntVectorTy()) if (Ty->isIntOrIntVectorTy())
return Create(Instruction::PtrToInt, S, Ty, Name, InsertAtEnd); return Create(Instruction::PtrToInt, S, Ty, Name, InsertAtEnd);
return CreatePointerBitCastOrAddrSpaceCast(S, Ty, Name, InsertAtEnd); return CreatePointerBitCastOrAddrSpaceCast(S, Ty, Name, InsertAtEnd);
} }
/// Create a BitCast or a PtrToInt cast instruction /// Create a BitCast or a PtrToInt cast instruction
CastInst *CastInst::CreatePointerCast(Value *S, Type *Ty, CastInst *CastInst::CreatePointerCast(Value *S, Type *Ty,
const Twine &Name, const Twine &Name,
Instruction *InsertBefore) { Instruction *InsertBefore) {
assert(S->getType()->isPtrOrPtrVectorTy() && "Invalid cast"); assert(S->getType()->isPtrOrPtrVectorTy() && "Invalid cast");
assert((Ty->isIntOrIntVectorTy() || Ty->isPtrOrPtrVectorTy()) && assert((Ty->isIntOrIntVectorTy() || Ty->isPtrOrPtrVectorTy()) &&
"Invalid cast"); "Invalid cast");
assert(Ty->isVectorTy() == S->getType()->isVectorTy() && "Invalid cast"); assert(Ty->isVectorTy() == S->getType()->isVectorTy() && "Invalid cast");
assert((!Ty->isVectorTy() || assert((!Ty->isVectorTy() ||
cast<FixedVectorType>(Ty)->getNumElements() == cast<VectorType>(Ty)->getElementCount() ==
cast<FixedVectorType>(S->getType())->getNumElements()) && cast<VectorType>(S->getType())->getElementCount()) &&
"Invalid cast"); "Invalid cast");
if (Ty->isIntOrIntVectorTy()) if (Ty->isIntOrIntVectorTy())
return Create(Instruction::PtrToInt, S, Ty, Name, InsertBefore); return Create(Instruction::PtrToInt, S, Ty, Name, InsertBefore);
return CreatePointerBitCastOrAddrSpaceCast(S, Ty, Name, InsertBefore); return CreatePointerBitCastOrAddrSpaceCast(S, Ty, Name, InsertBefore);
} }
▲ Show 20 Lines • Show All 1,470 Lines • Show Last 20 Lines

llvm/unittests/IR/InstructionsTest.cpp

Show First 20 Lines • Show All 368 Lines • ▼ Show 20 LinesTEST(InstructionsTest, CastInst) {
// Check that assertion is not hit when creating a cast with a vector of // Check that assertion is not hit when creating a cast with a vector of
// pointers // pointers
// First form // First form
BasicBlock *BB = BasicBlock::Create(C); BasicBlock *BB = BasicBlock::Create(C);
Constant *NullV2I32Ptr = Constant::getNullValue(V2Int32PtrTy); Constant *NullV2I32Ptr = Constant::getNullValue(V2Int32PtrTy);
auto Inst1 = CastInst::CreatePointerCast(NullV2I32Ptr, V2Int32Ty, "foo", BB); auto Inst1 = CastInst::CreatePointerCast(NullV2I32Ptr, V2Int32Ty, "foo", BB);
Constant *NullVScaleV2I32Ptr = Constant::getNullValue(VScaleV2Int32PtrTy);
auto Inst1VScale = CastInst::CreatePointerCast(
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: 'auto Inst1VScale' can be declared as 'auto *Inst1VScale' [llvm-qualified-auto]
not useful

Lint: Pre-merge checks: clang-tidy: warning: 'auto Inst1VScale' can be declared as 'auto *Inst1VScale' [llvm-qualified…
NullVScaleV2I32Ptr, VScaleV2Int32Ty, "foo.vscale", BB);
// Second form // Second form
auto Inst2 = CastInst::CreatePointerCast(NullV2I32Ptr, V2Int32Ty); auto Inst2 = CastInst::CreatePointerCast(NullV2I32Ptr, V2Int32Ty);
auto Inst2VScale =
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: 'auto Inst2VScale' can be declared as 'auto *Inst2VScale' [llvm-qualified-auto]
not useful

Lint: Pre-merge checks: clang-tidy: warning: 'auto Inst2VScale' can be declared as 'auto *Inst2VScale' [llvm-qualified…
CastInst::CreatePointerCast(NullVScaleV2I32Ptr, VScaleV2Int32Ty);
delete Inst2; delete Inst2;
delete Inst2VScale;
Inst1->eraseFromParent(); Inst1->eraseFromParent();
Inst1VScale->eraseFromParent();
delete BB; delete BB;
} }
TEST(InstructionsTest, VectorGep) { TEST(InstructionsTest, VectorGep) {
LLVMContext C; LLVMContext C;
// Type Definitions // Type Definitions
Type *I8Ty = IntegerType::get(C, 8); Type *I8Ty = IntegerType::get(C, 8);
▲ Show 20 Lines • Show All 1,089 Lines • Show Last 20 Lines