This is an archive of the discontinued LLVM Phabricator instance.

In D92477#2430980, @Paul-C-Anagnostopoulos wrote:

Cool! It had seen the TODO and planned to do something about it, but didn't realize the class wasn't used at all.

I think it has been unused since D43652 and/or D44478.

This revision was landed with ongoing or failed builds.Dec 3 2020, 5:37 AM

Closed by commit rG0f32e81407d3: [TableGen] Remove unused class RecordValResolver. NFC. (authored by foad). · Explain Why

This revision was automatically updated to reflect the committed changes.

foad added a commit: rG0f32e81407d3: [TableGen] Remove unused class RecordValResolver. NFC..

Revision Contents

Path

Size

llvm/

include/

llvm/

TableGen/

Record.h

19 lines

Diff 309234

llvm/include/llvm/TableGen/Record.h

	Show First 20 Lines • Show All 2,026 Lines • ▼ Show 20 Lines
	public:			public:
	explicit RecordResolver(Record &R) : Resolver(&R) {}			explicit RecordResolver(Record &R) : Resolver(&R) {}

	Init resolve(Init VarName) override;			Init resolve(Init VarName) override;

	bool keepUnsetBits() const override { return true; }			bool keepUnsetBits() const override { return true; }
	};			};

	/// Resolve all references to a specific RecordVal.
	//
	// TODO: This is used for resolving references to template arguments, in a
	// rather inefficient way. Change those uses to resolve all template
	// arguments simultaneously and get rid of this class.
	class RecordValResolver final : public Resolver {
	const RecordVal *RV;

	public:
	explicit RecordValResolver(Record &R, const RecordVal *RV)
	: Resolver(&R), RV(RV) {}

	Init resolve(Init VarName) override {
	if (VarName == RV->getNameInit())
	return RV->getValue();
	return nullptr;
	}
	};

	/// Delegate resolving to a sub-resolver, but shadow some variable names.			/// Delegate resolving to a sub-resolver, but shadow some variable names.
	class ShadowResolver final : public Resolver {			class ShadowResolver final : public Resolver {
	Resolver &R;			Resolver &R;
	DenseSet<Init *> Shadowed;			DenseSet<Init *> Shadowed;

	public:			public:
	explicit ShadowResolver(Resolver &R)			explicit ShadowResolver(Resolver &R)
	: Resolver(R.getCurrentRecord()), R(R) {			: Resolver(R.getCurrentRecord()), R(R) {
	▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Remove unused class RecordValResolver. NFC.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 309234

llvm/include/llvm/TableGen/Record.h

[TableGen] Remove unused class RecordValResolver. NFC.
ClosedPublic