Page MenuHomePhabricator

[mlir][IR] Remove references to BuiltinOps from IR/
ClosedPublic

Authored by rriddle on Dec 1 2020, 7:12 PM.

Details

Summary

There isn't a good reason for anything within IR to specifically reference any of the builtin operations. The only place that had a good reason in the past was AsmPrinter, but the behavior there doesn't need to hardcode ModuleOp anymore.

Diff Detail

Event Timeline

rriddle created this revision.Dec 1 2020, 7:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 7:12 PM
rriddle requested review of this revision.Dec 1 2020, 7:12 PM
mehdi_amini accepted this revision.Dec 1 2020, 7:40 PM

Nice cleanup!

This revision is now accepted and ready to land.Dec 1 2020, 7:40 PM
jpienaar accepted this revision.Dec 1 2020, 7:47 PM
This revision was landed with ongoing or failed builds.Dec 3 2020, 3:53 PM
This revision was automatically updated to reflect the committed changes.