This is an archive of the discontinued LLVM Phabricator instance.

Differential D92333

[MLIR][LLVM] Fix a tiny typo in the dialect docs.
ClosedPublic

Authored by ergawy on Nov 30 2020, 9:50 AM.

Details

Reviewers
ftynse
rriddle
Commits
rG2074fec5beb4: [MLIR][LLVM] Fix a tiny typo in the dialect docs.

Diff Detail

Event Timeline

ergawy created this revision.Nov 30 2020, 9:50 AM
Herald added a reviewer: ftynse. · View Herald TranscriptNov 30 2020, 9:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald Transcript
ergawy requested review of this revision.Nov 30 2020, 9:50 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 30 2020, 9:50 AM
rriddle accepted this revision.Nov 30 2020, 9:57 AM
This revision is now accepted and ready to land.Nov 30 2020, 9:57 AM
Harbormaster completed remote builds in B80546: Diff 308407.Nov 30 2020, 10:13 AM
ergawy added a comment.Dec 1 2020, 5:32 AM

I don't have commit access. Please commit on my behalf whenever you like.

Closed by commit rG2074fec5beb4: [MLIR][LLVM] Fix a tiny typo in the dialect docs. (authored by ergawy, committed by mehdi_amini). · Explain WhyDec 1 2020, 12:07 PM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG2074fec5beb4: [MLIR][LLVM] Fix a tiny typo in the dialect docs..

Revision Contents

PathSize
mlir/
docs/
Dialects/
4 lines

Diff 308733

mlir/docs/Dialects/LLVM.md

Show First 20 Lines • Show All 468 Lines • ▼ Show 20 Lines
// symbol resolution at link-time. // symbol resolution at link-time.
llvm.mlir.global @glob(0 : f32) : !llvm.float llvm.mlir.global @glob(0 : f32) : !llvm.float
``` ```
#### `llvm.mlir.null` #### `llvm.mlir.null`
Unlike LLVM IR, MLIR does not have first-class null pointers. They must be Unlike LLVM IR, MLIR does not have first-class null pointers. They must be
explicitly created as SSA values using `llvm.mlir.null`. This operation has explicitly created as SSA values using `llvm.mlir.null`. This operation has
operands or attributes, and returns a null value of a wrapped LLVM IR pointer no operands or attributes, and returns a null value of a wrapped LLVM IR
type. pointer type.
Examples: Examples:
```mlir ```mlir
// Null pointer to i8 value. // Null pointer to i8 value.
%0 = llvm.mlir.null : !llvm<"i8*"> %0 = llvm.mlir.null : !llvm<"i8*">
// Null pointer to a function with signature void() value. // Null pointer to a function with signature void() value.
Show All 16 Lines