Page MenuHomePhabricator

[AIX] Enabling vector type arguments and return for AIX
ClosedPublic

Authored by ZarkoCA on Nov 25 2020, 10:50 AM.

Details

Summary

This patch enables vector type arguments on AIX. All non-aggregate Altivec vector types are 16bytes in size and are 16byte aligned.

Diff Detail

Event Timeline

ZarkoCA created this revision.Nov 25 2020, 10:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2020, 10:50 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ZarkoCA requested review of this revision.Nov 25 2020, 10:50 AM
ZarkoCA retitled this revision from [AIX] Enabling vectory types for AIX to [AIX] Enabling vector types for AIX.Nov 25 2020, 11:53 AM
Xiangling_L accepted this revision.Nov 25 2020, 1:44 PM

Just a minor suggestion: Maybe Enabling return and argument vector types for AIX is more accurate. Otherwise, LGTM.

clang/test/CodeGen/aix-altivec.c
6

minor:
you can use [[ATTR:#[0-9]+]] to replace #0

This revision is now accepted and ready to land.Nov 25 2020, 1:44 PM
ZarkoCA updated this revision to Diff 307748.Nov 25 2020, 7:29 PM

Added regex and variable for function attribute

ZarkoCA retitled this revision from [AIX] Enabling vector types for AIX to [AIX] Enabling vector type arguments and return for AIX.Nov 25 2020, 7:33 PM
ZarkoCA edited the summary of this revision. (Show Details)
ZarkoCA marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.