This is an archive of the discontinued LLVM Phabricator instance.

Differential D92023

[MLIR] Fix TableGen generator for attribute interfaces.
ClosedPublic

Authored by ulysseB on Nov 24 2020, 4:43 AM.

Details

Reviewers
ftynse
Commits
rG1eded173a91d: [MLIR] Fix TableGen generator for attribute interfaces.
Summary

Use the correct interface base type name when generating attribute interfaces
with TabeGen.

Diff Detail

Event Timeline

ulysseB created this revision.Nov 24 2020, 4:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2020, 4:43 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald Transcript
ulysseB requested review of this revision.Nov 24 2020, 4:43 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 24 2020, 4:43 AM
ulysseB added a reviewer: ftynse.Nov 24 2020, 4:44 AM
ftynse accepted this revision.Nov 24 2020, 4:54 AM
This revision is now accepted and ready to land.Nov 24 2020, 4:54 AM
Harbormaster completed remote builds in B79931: Diff 307316.Nov 24 2020, 4:59 AM
Closed by commit rG1eded173a91d: [MLIR] Fix TableGen generator for attribute interfaces. (authored by ulysseB, committed by ftynse). · Explain WhyNov 24 2020, 5:06 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG1eded173a91d: [MLIR] Fix TableGen generator for attribute interfaces..
mehdi_amini added a comment.Nov 24 2020, 12:54 PM

Can you add a test for this in-tree please?

Herald added a subscriber: nimiwio. · View Herald TranscriptNov 24 2020, 12:54 PM

Revision Contents

PathSize
mlir/
tools/
mlir-tblgen/
2 lines

Diff 307318

mlir/tools/mlir-tblgen/OpInterfacesGen.cpp

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
}; };
/// A specialized generator for attribute interfaces. /// A specialized generator for attribute interfaces.
struct AttrInterfaceGenerator : public InterfaceGenerator { struct AttrInterfaceGenerator : public InterfaceGenerator {
AttrInterfaceGenerator(const llvm::RecordKeeper &records, raw_ostream &os) AttrInterfaceGenerator(const llvm::RecordKeeper &records, raw_ostream &os)
: InterfaceGenerator(records.getAllDerivedDefinitions("AttrInterface"), : InterfaceGenerator(records.getAllDerivedDefinitions("AttrInterface"),
os) { os) {
valueType = "::mlir::Attribute"; valueType = "::mlir::Attribute";
interfaceBaseType = "AttrInterface"; interfaceBaseType = "AttributeInterface";
valueTemplate = "ConcreteAttr"; valueTemplate = "ConcreteAttr";
StringRef castCode = "(tablegen_opaque_val.cast<ConcreteAttr>())"; StringRef castCode = "(tablegen_opaque_val.cast<ConcreteAttr>())";
nonStaticMethodFmt.addSubst("_attr", castCode).withSelf(castCode); nonStaticMethodFmt.addSubst("_attr", castCode).withSelf(castCode);
traitMethodFmt.addSubst("_attr", traitMethodFmt.addSubst("_attr",
"(*static_cast<const ConcreteAttr *>(this))"); "(*static_cast<const ConcreteAttr *>(this))");
} }
}; };
/// A specialized generator for operation interfaces. /// A specialized generator for operation interfaces.
▲ Show 20 Lines • Show All 334 Lines • Show Last 20 Lines