This is an archive of the discontinued LLVM Phabricator instance.

Differential D91951

[clangd] Get rid of clangToolingRefactoring dependency
ClosedPublic

Authored by kbobyrev on Nov 23 2020, 2:45 AM.

Details

Reviewers
hokein
Commits
rG1319c6624ed6: [clangd] Get rid of clangToolingRefactoring dependency
Summary

D71880 makes this dependency redundant and we can safely remove it. Tested for
both shared lib build and static lib build.

Diff Detail

Event Timeline

kbobyrev created this revision.Nov 23 2020, 2:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2020, 2:45 AM
Herald added subscribers: cfe-commits, usaxena95, kadircet and 2 others. · View Herald Transcript
kbobyrev requested review of this revision.Nov 23 2020, 2:45 AM
Herald added subscribers: MaskRay, ilya-biryukov. · View Herald TranscriptNov 23 2020, 2:45 AM
hokein accepted this revision.Nov 23 2020, 2:48 AM
This revision is now accepted and ready to land.Nov 23 2020, 2:48 AM
This revision was landed with ongoing or failed builds.Nov 23 2020, 3:00 AM
Closed by commit rG1319c6624ed6: [clangd] Get rid of clangToolingRefactoring dependency (authored by kbobyrev). · Explain Why
This revision was automatically updated to reflect the committed changes.
kbobyrev added a commit: rG1319c6624ed6: [clangd] Get rid of clangToolingRefactoring dependency.
Harbormaster completed remote builds in B79770: Diff 307016.Nov 23 2020, 3:38 AM

Revision Contents

PathSize
clang-tools-extra/
clangd/
1 line

Diff 307019

clang-tools-extra/clangd/CMakeLists.txt

Show First 20 Lines • Show All 134 Lines • ▼ Show 20 Linesclang_target_link_libraries(clangDaemon
clangFrontend clangFrontend
clangIndex clangIndex
clangLex clangLex
clangSema clangSema
clangSerialization clangSerialization
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingInclusions clangToolingInclusions
clangToolingRefactoring
clangToolingSyntax clangToolingSyntax
) )
target_link_libraries(clangDaemon target_link_libraries(clangDaemon
PRIVATE PRIVATE
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
clangTidy clangTidy
Show All 34 Lines