Use MlirStringRef throughout the C API

[GeorgeLyon]

Summary

While this makes the unit tests a bit more verbose, this simplifies the creation of bindings because only the bidirectional mapping between the host language's string type and MlirStringRef need to be implemented.

[GeorgeLyon]

Removing spurious formatting changes

[mehdi_amini]

mlir/include/mlir-c/IR.h

155

I rather keep the name mlirLocationFileLineColGet and not expose the const char * one: otherwise we'll have to "overload" every API with StringRef and char*

[GeorgeLyon]

To be perfectly clear, I agree that we should use MlirStringRef throughout, but if we decide that we should do that across the API in one fell swoop (I’m happy to author that PR if folks are on board).

@ftynse thoughts?

[ftynse]

Sure, let's use MlirStringRef everywhere, this also indicates that we don't take ownership of the string. We added it much later than APIs that could be using it and nobody had time to reconsider those yet.

[GeorgeLyon]

Use MlirStringRef throughout the API.

[GeorgeLyon]

Fix formatting

[GeorgeLyon]

Use MlirStringRef for all strings in the C API

[GeorgeLyon]

Use MlirStringRef for all strings in the C API

[GeorgeLyon]

Use MlirStringRef throught the C API

[GeorgeLyon]

Sorry for the spam, I am still learning my way around arc diff. This should be ready now though.

[GeorgeLyon]

Some more formatting fixes

[ftynse]

FYI: your email address wasn't picked up by git when landing - Author: George <>

mlir/include/mlir-c/IR.h

 //===----------------------------------------------------------------------===//
 
 /// Creates an File/Line/Column location owned by the given context.
 MLIR_CAPI_EXPORTED MlirLocation mlirLocationFileLineColGet(MlirContext context,
                                                            const char *filename,
                                                            unsigned line,
                                                            unsigned col);
 
+/** Creates an File/Line/Column location owned by the given context using an
+ * MlirStringRef for the filename. */
+MLIR_CAPI_EXPORTED MlirLocation mlirLocationFileStringRefLineColGet(
+    MlirContext context, MlirStringRef filename, unsigned line, unsigned col);
+
 /// Creates a location with unknown position owned by the given context.
 MLIR_CAPI_EXPORTED MlirLocation mlirLocationUnknownGet(MlirContext context);
 
 /// Gets the context that a location was created with.
 MLIR_CAPI_EXPORTED MlirContext mlirLocationGetContext(MlirLocation location);
 
 /** Prints a location by sending chunks of the string representation and
  * forwarding `userData to `callback`. Note that the callback may be called

mlir/lib/CAPI/IR/IR.cpp

 //===----------------------------------------------------------------------===//
 
 MlirLocation mlirLocationFileLineColGet(MlirContext context,
                                         const char *filename, unsigned line,
                                         unsigned col) {
   return wrap(FileLineColLoc::get(filename, line, col, unwrap(context)));
 }
 
+MlirLocation mlirLocationFileStringRefLineColGet(MlirContext context,
+                                                 MlirStringRef filename,
+                                                 unsigned line, unsigned col) {
+  return wrap(
+      FileLineColLoc::get(unwrap(filename), line, col, unwrap(context)));
+}
+
 MlirLocation mlirLocationUnknownGet(MlirContext context) {
   return wrap(UnknownLoc::get(unwrap(context)));
 }
 
 MlirContext mlirLocationGetContext(MlirLocation location) {
   return wrap(unwrap(location).getContext());
 }