This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG][X86][PowerPC][Mips] Replace the default implementation of LowerOperationWrapper with the X86 and PowerPC version.
ClosedPublic

Authored by craig.topper on Nov 19 2020, 11:57 PM.

Details

Summary

The default version only works if the returned node has a single
result. The X86 and PowerPC versions support multiple results
and allow a single result to be returned from a node with
multiple outputs. And allow a single result that is not result 0
of the node.

Also replace the Mips version since the new version should work
for it. The original version handled multiple results, but only
if the new node and original node had the same number of results.

Diff Detail

Event Timeline

craig.topper created this revision.Nov 19 2020, 11:57 PM
craig.topper requested review of this revision.Nov 19 2020, 11:57 PM
RKSimon accepted this revision.Nov 20 2020, 3:31 AM

LGTM

This revision is now accepted and ready to land.Nov 20 2020, 3:31 AM
nemanjai accepted this revision.Nov 20 2020, 4:33 AM

LGTM. Thanks for commoning this.

This revision was landed with ongoing or failed builds.Nov 20 2020, 10:07 AM
This revision was automatically updated to reflect the committed changes.