This is an archive of the discontinued LLVM Phabricator instance.

Differential D91642

[AArch64][SVE] Add tests for VLST -> VLAT lax conversions
ClosedPublic

Authored by joechrisellis on Nov 17 2020, 9:34 AM.

Details

Reviewers
fpetrogalli
efriedma
Commits
rG1d7abcf99e3d: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions
Summary

These were previously missing from the SVE lax conversions tests.

Diff Detail

Event Timeline

joechrisellis created this revision.Nov 17 2020, 9:34 AM
Herald added a reviewer: efriedma. · View Herald TranscriptNov 17 2020, 9:34 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. · View Herald Transcript
joechrisellis requested review of this revision.Nov 17 2020, 9:34 AM
fpetrogalli accepted this revision.Nov 17 2020, 9:36 AM

HI @joechrisellis - thank you. This LGTM.

Please make sure to specify a link to the original patch on phabricator in the commit message before submitting.

This revision is now accepted and ready to land.Nov 17 2020, 9:36 AM
This revision was landed with ongoing or failed builds.Nov 17 2020, 10:04 AM
Closed by commit rG1d7abcf99e3d: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions (authored by joechrisellis). · Explain Why
This revision was automatically updated to reflect the committed changes.
joechrisellis added a commit: rG1d7abcf99e3d: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions.
Harbormaster completed remote builds in B79144: Diff 305833.Nov 17 2020, 10:43 AM

Revision Contents

Diff 305840

clang/test/Sema/aarch64-sve-lax-vector-conversions.c

Show All 14 Lines
void allowed_with_integer_lax_conversions() { void allowed_with_integer_lax_conversions() {
fixed_int32_t fi32; fixed_int32_t fi32;
svint64_t si64; svint64_t si64;
// The implicit cast here should fail if -flax-vector-conversions=none, but pass if // The implicit cast here should fail if -flax-vector-conversions=none, but pass if
// -flax-vector-conversions={integer,all}. // -flax-vector-conversions={integer,all}.
fi32 = si64; fi32 = si64;
// lax-vector-none-error@-1 {{assigning to 'fixed_int32_t' (vector of 16 'int' values) from incompatible type}} // lax-vector-none-error@-1 {{assigning to 'fixed_int32_t' (vector of 16 'int' values) from incompatible type}}
si64 = fi32;
// lax-vector-none-error@-1 {{assigning to 'svint64_t' (aka '__SVInt64_t') from incompatible type}}
} }
void allowed_with_all_lax_conversions() { void allowed_with_all_lax_conversions() {
fixed_float32_t ff32; fixed_float32_t ff32;
svfloat64_t sf64; svfloat64_t sf64;
// The implicit cast here should fail if -flax-vector-conversions={none,integer}, but pass if // The implicit cast here should fail if -flax-vector-conversions={none,integer}, but pass if
// -flax-vector-conversions=all. // -flax-vector-conversions=all.
ff32 = sf64; ff32 = sf64;
// lax-vector-none-error@-1 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}} // lax-vector-none-error@-1 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}}
// lax-vector-integer-error@-2 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}} // lax-vector-integer-error@-2 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}}
sf64 = ff32;
// lax-vector-none-error@-1 {{assigning to 'svfloat64_t' (aka '__SVFloat64_t') from incompatible type}}
// lax-vector-integer-error@-2 {{assigning to 'svfloat64_t' (aka '__SVFloat64_t') from incompatible type}}
} }

clang/test/SemaCXX/aarch64-sve-lax-vector-conversions.cpp

Show All 14 Lines
void allowed_with_integer_lax_conversions() { void allowed_with_integer_lax_conversions() {
fixed_int32_t fi32; fixed_int32_t fi32;
svint64_t si64; svint64_t si64;
// The implicit cast here should fail if -flax-vector-conversions=none, but pass if // The implicit cast here should fail if -flax-vector-conversions=none, but pass if
// -flax-vector-conversions={integer,all}. // -flax-vector-conversions={integer,all}.
fi32 = si64; fi32 = si64;
// lax-vector-none-error@-1 {{assigning to 'fixed_int32_t' (vector of 16 'int' values) from incompatible type}} // lax-vector-none-error@-1 {{assigning to 'fixed_int32_t' (vector of 16 'int' values) from incompatible type}}
si64 = fi32;
// lax-vector-none-error@-1 {{assigning to 'svint64_t' (aka '__SVInt64_t') from incompatible type}}
} }
void allowed_with_all_lax_conversions() { void allowed_with_all_lax_conversions() {
fixed_float32_t ff32; fixed_float32_t ff32;
svfloat64_t sf64; svfloat64_t sf64;
// The implicit cast here should fail if -flax-vector-conversions={none,integer}, but pass if // The implicit cast here should fail if -flax-vector-conversions={none,integer}, but pass if
// -flax-vector-conversions=all. // -flax-vector-conversions=all.
ff32 = sf64; ff32 = sf64;
// lax-vector-none-error@-1 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}} // lax-vector-none-error@-1 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}}
// lax-vector-integer-error@-2 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}} // lax-vector-integer-error@-2 {{assigning to 'fixed_float32_t' (vector of 16 'float' values) from incompatible type}}
sf64 = ff32;
// lax-vector-none-error@-1 {{assigning to 'svfloat64_t' (aka '__SVFloat64_t') from incompatible type}}
// lax-vector-integer-error@-2 {{assigning to 'svfloat64_t' (aka '__SVFloat64_t') from incompatible type}}
} }