Page MenuHomePhabricator

[mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr().
ClosedPublic

Authored by csigg on Nov 17 2020, 1:23 AM.

Details

Summary

Make the interface match the one of ConvertToLLVMPattern::getDataPtr() (to be removed in a separate change).

Diff Detail

Event Timeline

csigg created this revision.Nov 17 2020, 1:23 AM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
csigg requested review of this revision.Nov 17 2020, 1:23 AM
ftynse accepted this revision.Nov 17 2020, 3:37 PM

Thanks, looks much simpler!

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
1067–1069

Nit: there is isStrided that does this

This revision is now accepted and ready to land.Nov 17 2020, 3:37 PM