This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Make Clang recognize -cl-std=1.0 as a value argument
ClosedPublic

Authored by Elvina on Nov 10 2020, 11:22 PM.

Details

Summary

This patch makes Clang recognize -cl-std=1.0 as a value argument, before only -std=cl1.0 has to be used instead.
Fixes https://bugs.llvm.org/show_bug.cgi?id=47981

Yours,
Elvina
Software Engineer
Advanced Software Technology Lab, Huawei

Diff Detail

Event Timeline

Elvina created this revision.Nov 10 2020, 11:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 11:22 PM
Elvina requested review of this revision.Nov 10 2020, 11:22 PM

Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I had the same issue with another PR https://reviews.llvm.org/D89972 and other people also faced it https://reviews.llvm.org/D89895

Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I had the same issue with another PR https://reviews.llvm.org/D89972 and other people also faced it https://reviews.llvm.org/D89895

I agree they don't work very well, unfortunately.

Anastasia accepted this revision.Nov 11 2020, 5:15 AM

LGTM! Thanks for fixing this.

This revision is now accepted and ready to land.Nov 11 2020, 5:15 AM

Anastasia, thank you

This revision was landed with ongoing or failed builds.Nov 11 2020, 6:04 AM
This revision was automatically updated to reflect the committed changes.