Page MenuHomePhabricator

[libc++] Fix two fr_FR locale tests on FreeBSD
ClosedPublic

Authored by arichardson on Nov 10 2020, 7:40 AM.

Details

Summary

FreeBSD's locale data appears to use the same U+2027 separator as Glibc
2.27 and newer.

Diff Detail

Event Timeline

arichardson created this revision.Nov 10 2020, 7:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 7:40 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
arichardson requested review of this revision.Nov 10 2020, 7:40 AM
emaste accepted this revision.Nov 10 2020, 7:59 AM

This is fine with me; have we always done that?

This is fine with me; have we always done that?

Looks like the file changed in 2018 (https://github.com/freebsd/freebsd/commit/85d52a26546e940979f91b8ba0b8ac54faa362ad). It works for me on a 12.1-RELEASE-p8 system, I'm not sure if we need to add a runtime check?

I'm not sure if we need to add a runtime check?

I don't think so; I'm not too concerned whether this test passes or not on 11.x and 12.1 is the oldest supported 12.x release at present.
Maybe add a (as of 2018) note in the comment?

ldionne accepted this revision.Nov 20 2020, 12:01 PM
This revision is now accepted and ready to land.Nov 20 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.