This is an archive of the discontinued LLVM Phabricator instance.

Differential D91064

[MachineBasicBlock] Fix update of live intervals in splitAt
AbandonedPublic

Authored by critson on Nov 9 2020, 3:02 AM.

Download Raw Diff

Details

Reviewers

arsenm
MaskRay

Summary

In splitAt the wrong insertion point is passed to insertMBBInMaps.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	370 ms	linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
	470 ms	windows > lld.ELF/invalid::symtab-sh-info.s

Event Timeline

critson created this revision.Nov 9 2020, 3:02 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2020, 3:02 AM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

critson requested review of this revision.Nov 9 2020, 3:02 AM

Herald added a subscriber: wdng. · View Herald TranscriptNov 9 2020, 3:02 AM

Harbormaster completed remote builds in B78091: Diff 303804.Nov 9 2020, 3:57 AM

Any test?

This revision is now accepted and ready to land.Nov 9 2020, 10:53 AM

Add tests, but these depend on D91066

Herald added a subscriber: MatzeB. · View Herald TranscriptNov 9 2020, 7:12 PM

critson added a parent revision: D91066: [SlotIndexes] Consider existing index range in insertMBBIntoMaps.Nov 9 2020, 7:13 PM

Harbormaster completed remote builds in B78211: Diff 304027.Nov 9 2020, 7:44 PM

arsenm accepted this revision.Nov 10 2020, 7:49 AM

critson added a child revision: D67767: [AMDGPU] Add llvm.amdgcn.wqm.demote intrinsic and live mask tracking.Nov 10 2020, 7:17 PM

critson mentioned this in D91066: [SlotIndexes] Consider existing index range in insertMBBIntoMaps.Dec 3 2020, 7:01 PM

Rebase

Harbormaster completed remote builds in B84425: Diff 315306.Jan 8 2021, 1:06 AM

arsenm accepted this revision.Jan 8 2021, 6:12 AM

foad mentioned this in D94311: [SlotIndexes] Fix and simplify basic block splitting.Jan 8 2021, 8:03 AM

Superseded by D94311.

Revision Contents

Path

Size

llvm/

lib/

CodeGen/

MachineBasicBlock.cpp

2 lines

Diff 303804

llvm/lib/CodeGen/MachineBasicBlock.cpp

	Show First 20 Lines • Show All 978 Lines • ▼ Show 20 Lines		MachineBasicBlock *MachineBasicBlock::splitAt(MachineInstr &MI,

	SplitBB->transferSuccessorsAndUpdatePHIs(this);			SplitBB->transferSuccessorsAndUpdatePHIs(this);
	addSuccessor(SplitBB);			addSuccessor(SplitBB);

	if (UpdateLiveIns)			if (UpdateLiveIns)
	addLiveIns(*SplitBB, LiveRegs);			addLiveIns(*SplitBB, LiveRegs);

	if (LIS)			if (LIS)
	LIS->insertMBBInMaps(SplitBB, &MI);			LIS->insertMBBInMaps(SplitBB, &*SplitPoint);

	return SplitBB;			return SplitBB;
	}			}

	MachineBasicBlock *MachineBasicBlock::SplitCriticalEdge(			MachineBasicBlock *MachineBasicBlock::SplitCriticalEdge(
	MachineBasicBlock *Succ, Pass &P,			MachineBasicBlock *Succ, Pass &P,
	std::vector<SparseBitVector<>> *LiveInSets) {			std::vector<SparseBitVector<>> *LiveInSets) {
	if (!canSplitCriticalEdge(Succ))			if (!canSplitCriticalEdge(Succ))
	▲ Show 20 Lines • Show All 583 Lines • Show Last 20 Lines