Remove TOSA test passes from non test registration.

[stellaraccident]

Summary

• Wires them in the same way that peer-dialect test passes are registered.
• Fixes the build for -DLLVM_INCLUDE_TESTS=OFF.

[stellaraccident]

Mehdi: I just followed the example of how this is done for Affine. Not sure if there is a plan to systematize these test passes long term.

[mehdi_amini]

LG!

mlir/include/mlir/Dialect/Tosa/Transforms/Passes.td

let description = [{
     number of dimensions. Insert RESHAPE operations to prepend dimensions
     of size one until the number of dimensions is equal. Implements
     approach similar to step 1 of Numpy 4-step broadcasting:
     https://numpy.org/doc/stable/reference/ufuncs.html#broadcasting
   }];
 
   let constructor = "createTosaMakeBroadcastablePass()";
 }
-
-// TOSA Test Passes
-
-def TosaTestQuantUtils : FunctionPass<"tosa-test-quant-utils"> {
-  let summary = "TOSA Test: Exercise the APIs in QuantUtils.cpp";
-  let description = [{
-    Exercises the API that builds a quantized type from min/max quantized range.
-  }];
-
-  let constructor = "createTosaTestQuantUtilAPIPass()";
-}

mlir/test/lib/Dialect/Tosa/TosaTestPasses.cpp

 #include "mlir/Dialect/Tosa/Transforms/PassDetail.h"
 #include "mlir/Dialect/Tosa/Transforms/Passes.h"
 #include "mlir/Dialect/Tosa/Utils/QuantUtils.h"
 #include "mlir/IR/Matchers.h"
 #include "mlir/IR/StandardTypes.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Transforms/GreedyPatternRewriteDriver.h"
 
+#define PASS_NAME "tosa-test-quant-utils"
+
 using namespace mlir;
 using namespace mlir::tosa;
 
 // This transformation converts quantized uint8 to quantized int8. The
 // construction of the new type invokes buildQTypeFromMinMax. Extracted from
 // TOSA legalization infrastructure.
 struct ConvertTosaNegateOp : public RewritePattern {
   explicit ConvertTosaNegateOp(MLIRContext *context)
ConvertTosaConv2DOp::matchAndRewrite(Operation *op,
 
   rewriter.replaceOp(op, {newTosaRescaleOp.getResult()});
   return success();
 }
 
 namespace {
 
 struct TosaTestQuantUtilAPI
-    : public TosaTestQuantUtilsBase<TosaTestQuantUtilAPI> {
+    : public PassWrapper<TosaTestQuantUtilAPI, FunctionPass> {
   void runOnFunction() override;
 };
 
 void TosaTestQuantUtilAPI::runOnFunction() {
   OwningRewritePatternList patterns;
   auto *ctx = &getContext();
   auto func = getFunction();
 
   patterns.insert<ConvertTosaNegateOp>(ctx);
   patterns.insert<ConvertTosaConv2DOp>(ctx);
   applyPatternsAndFoldGreedily(func, std::move(patterns));
 }
 
 } // anonymous namespace
 
-std::unique_ptr<Pass> mlir::tosa::createTosaTestQuantUtilAPIPass() {
-  return std::make_unique<TosaTestQuantUtilAPI>();
+namespace mlir {
+void registerTosaTestQuantUtilAPIPass() {
+  PassRegistration<TosaTestQuantUtilAPI>(
+      PASS_NAME, "TOSA Test: Exercise the APIs in QuantUtils.cpp.");
 }
+} // namespace mlir

mlir/tools/mlir-opt/mlir-opt.cpp

 void registerTestLoopPermutationPass();
 void registerTestMatchers();
 void registerTestPrintDefUsePass();
 void registerTestPrintNestingPass();
 void registerTestReducer();
 void registerTestSpirvEntryPointABIPass();
 void registerTestSpirvModuleCombinerPass();
 void registerTestTraitsPass();
+void registerTosaTestQuantUtilAPIPass();
 void registerVectorizerTestPass();
 
 namespace test {
 void registerConvertCallOpPass();
 void registerInliner();
 void registerMemRefBoundCheck();
 void registerPatternsTestPass();
 void registerSimpleParametricTilingPass();
void registerTestPasses() {
   registerTestMatchers();
   registerTestPrintDefUsePass();
   registerTestPrintNestingPass();
   registerTestReducer();
   registerTestSpirvEntryPointABIPass();
   registerTestSpirvModuleCombinerPass();
   registerTestTraitsPass();
   registerVectorizerTestPass();
+  registerTosaTestQuantUtilAPIPass();
 
   test::registerConvertCallOpPass();
   test::registerInliner();
   test::registerMemRefBoundCheck();
   test::registerPatternsTestPass();
   test::registerSimpleParametricTilingPass();
   test::registerTestAffineLoopParametricTilingPass();
   test::registerTestCallGraphPass();