[lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

[mgorny]

Summary

Use skipUnlessDarwin decorator for tests that are specific to Darwin,
instead of skipIf... for all other platforms. This should make it clear
that these tests are not supposed to work elsewhere. It will also make
these tests stop repeatedly popping up while I look for tests that could
be fixed on the platform in question.

[teemperor]

Given that these are all Objective-C tests, this LGTM.

(Out of scope for this patch, but it would probably be cleaner if we replace all the skipUnlessDarwin uses because of Obj-C with a dedicated decorator. In theory Obj-C is available on other systems).

[mgorny]

In D91003#2380907, @teemperor wrote:

Given that these are all Objective-C tests, this LGTM.

(Out of scope for this patch, but it would probably be cleaner if we replace all the skipUnlessDarwin uses because of Obj-C with a dedicated decorator. In theory Obj-C is available on other systems).

I was kinda wondering why it is done like this, I've presumed some ObjC-specific parts of LLDB work only on Darwin.

[teemperor]

In D91003#2380921, @mgorny wrote:

In D91003#2380907, @teemperor wrote:

Given that these are all Objective-C tests, this LGTM.

(Out of scope for this patch, but it would probably be cleaner if we replace all the skipUnlessDarwin uses because of Obj-C with a dedicated decorator. In theory Obj-C is available on other systems).

I was kinda wondering why it is done like this, I've presumed some ObjC-specific parts of LLDB work only on Darwin.

I assume that's indeed the case given how much LLDB assumes about the implementation details of the Obj-C runtime.

[emaste]

In theory Obj-C is available on other systems

Yes, in particular it should be possible on FreeBSD. I agree that an Obj-C-specific decorator would be best but it's a very low priority.

[labath]

If we put all of the objc tests into objc-specific directories (it looks like most of them are there already, but I spotted two outliers in this patch), then we could mark those directories with the existing "objc" category, and use the existing category-based skipping mechanism. I don't remember seeing the code for setting the objc category, so I don't know how it works, but it shouldn't be hard to make it skip this category on platforms which don't (currently) support objc.

[mgorny]

In D91003#2381881, @labath wrote:

If we put all of the objc tests into objc-specific directories (it looks like most of them are there already, but I spotted two outliers in this patch), then we could mark those directories with the existing "objc" category, and use the existing category-based skipping mechanism. I don't remember seeing the code for setting the objc category, so I don't know how it works, but it shouldn't be hard to make it skip this category on platforms which don't (currently) support objc.

Actually, I've started working on this but I don't know how to reliably detect all Darwin platforms, with all the weird simulator environments and so on, from lit.

[teemperor]

In D91003#2381885, @mgorny wrote:

In D91003#2381881, @labath wrote:

If we put all of the objc tests into objc-specific directories (it looks like most of them are there already, but I spotted two outliers in this patch), then we could mark those directories with the existing "objc" category, and use the existing category-based skipping mechanism. I don't remember seeing the code for setting the objc category, so I don't know how it works, but it shouldn't be hard to make it skip this category on platforms which don't (currently) support objc.

Actually, I've started working on this but I don't know how to reliably detect all Darwin platforms, with all the weird simulator environments and so on, from lit.

Could you just do this via a feature check? For libc++ we try compiling a dummy file (grep for checkLibcxxSupport) and we could do the same with a very simple Obj-C program including NSObject.h.

[teemperor]

Actually that might not work for testing remote platforms that support Obj-C from non-ObjC hosts, so I guess we have to check if we're on Darwin.

[labath]

In D91003#2381892, @teemperor wrote:

In D91003#2381885, @mgorny wrote:

In D91003#2381881, @labath wrote:

If we put all of the objc tests into objc-specific directories (it looks like most of them are there already, but I spotted two outliers in this patch), then we could mark those directories with the existing "objc" category, and use the existing category-based skipping mechanism. I don't remember seeing the code for setting the objc category, so I don't know how it works, but it shouldn't be hard to make it skip this category on platforms which don't (currently) support objc.

Actually, I've started working on this but I don't know how to reliably detect all Darwin platforms, with all the weird simulator environments and so on, from lit.

Could you just do this via a feature check? For libc++ we try compiling a dummy file (grep for checkLibcxxSupport) and we could do the same with a very simple Obj-C program including NSObject.h.

Doing this from lit might be nice (save time doing the check only once), but the current state-of-the-art is to determine the supported categories from within dotest (checkLibcxxSupport and friends).

In D91003#2381904, @teemperor wrote:

Actually that might not work for testing remote platforms that support Obj-C from non-ObjC hosts, so I guess we have to check if we're on Darwin.

Moreover, I don't think that would actually reflect the state of the source code. I'd expect that debugging ObjC binary on some other platform would require an appropriate ObjCLanguageRuntime plugin (which we currently don't have).

lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py

 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfNetBSD, decorators.skipIfWindows])
+    __file__, globals(), [decorators.skipUnlessDarwin])

lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py

 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])

lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py

 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])

lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py

 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
     __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD,
+        decorators.skipUnlessDarwin,
         decorators.skipIf(archs=["i386", "i686"])])

lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py

 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])

lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py

 from lldbsuite.test import decorators
 from lldbsuite.test import lldbinline
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])

lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py

 import lldb
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test.decorators import *
 import lldbsuite.test.lldbutil as lldbutil
 import unittest2
 
 
 class TestObjCXXHideRuntimeSupportValues(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @skipIfFreeBSD
-    @skipIfLinux
-    @skipIfWindows
-    @skipIfNetBSD
+    @skipUnlessDarwin
     def test_hide_runtime_support_values(self):
         self.build()
         _, process, _, _ = lldbutil.run_to_source_breakpoint(
             self, 'break here', lldb.SBFileSpec('main.mm'))
 
         var_opts = lldb.SBVariablesOptions()
         var_opts.SetIncludeArguments(True)
         var_opts.SetIncludeLocals(True)

lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py

 from lldbsuite.test import decorators
 from lldbsuite.test import lldbinline
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])

lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py

 from lldbsuite.test import decorators
 from lldbsuite.test import lldbinline
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])

lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py

 from lldbsuite.test import decorators
 from lldbsuite.test import lldbinline
 
 lldbinline.MakeInlineTest(
     __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD,
+        decorators.skipUnlessDarwin,
         decorators.expectedFailureAll(
             oslist=['macosx'], archs=['i386'],
             bugnumber='rdar://28656677')])