Support multi-dimension vector for InsertMap/ExtractMap op and update the transformations. Currently the relation between IDs and dimension is implicitly deduced from the types. We can then calculate an AffineMap based on it. In the future the AffineMap could be part of the operation itself.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/Vector/VectorOps.td | ||
---|---|---|
467 | Made it id everywhere and reference ids to clarify it. |
few more nits
mlir/include/mlir/Dialect/Vector/VectorOps.td | ||
---|---|---|
468 | Can you please say a bit more about this "implicitly deduced", i.e. how it works. We use that phrase at a few places in our doc, but in general readers don't always find it obvious. Just stating the mechanism would help a lot improving our doc. | |
709 | came, or refer to the one above for details if you don't want to repeat | |
757–758 | ids | |
mlir/include/mlir/Dialect/Vector/VectorTransforms.h | ||
234 | ids |
mlir/include/mlir/Dialect/Vector/VectorOps.td | ||
---|---|---|
468 | Added more details. Hopefully that makes it clearer. |
mlir/lib/Dialect/Vector/VectorOps.cpp | ||
---|---|---|
1314 | It just means that the whitespace has changed. |
mlir/lib/Dialect/Vector/VectorOps.cpp | ||
---|---|---|
1314 | This is Phabricator display issue. This is how Phabricator shows that the line was indented but not modified. |
mlir/lib/Dialect/Vector/VectorOps.cpp | ||
---|---|---|
1314 | Thanks both for the background. |
you use small id and big ID. please unify, also perhaps link it clearl yback to the id variadic in the doc