This is an archive of the discontinued LLVM Phabricator instance.

Differential D90913

[AArch64][MC] Remove unused prefix in v8.4-a trace test
ClosedPublic

Authored by DavidSpickett on Nov 6 2020, 1:46 AM.

Details

Reviewers
ostannard
SjoerdMeijer
Commits
rG42848b827090: [AArch64][MC] Remove unused prefix in v8.4-a trace test
Summary

It was unused when added and the CHECK-ERROR lines
cover the possible outputs.

Diff Detail

Unit TestsFailed

TimeTest
40 mslinux > Clang.CodeGen::lto-newpm-pipeline.c
380 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
720 mslinux > LLVM.Other::new-pass-manager.ll

Event Timeline

DavidSpickett created this revision.Nov 6 2020, 1:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2020, 1:46 AM
Herald added subscribers: llvm-commits, danielkiss, kristof.beyls. · View Herald Transcript
DavidSpickett requested review of this revision.Nov 6 2020, 1:46 AM
DavidSpickett added reviewers: ostannard, SjoerdMeijer.Nov 6 2020, 1:48 AM
ostannard accepted this revision.Nov 6 2020, 1:54 AM

LGTM

This revision is now accepted and ready to land.Nov 6 2020, 1:54 AM
Harbormaster completed remote builds in B77843: Diff 303372.Nov 6 2020, 2:45 AM
This revision was landed with ongoing or failed builds.Nov 6 2020, 3:17 AM
Closed by commit rG42848b827090: [AArch64][MC] Remove unused prefix in v8.4-a trace test (authored by DavidSpickett). · Explain Why
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rG42848b827090: [AArch64][MC] Remove unused prefix in v8.4-a trace test.

Revision Contents

PathSize
llvm/
test/
MC/
AArch64/
2 lines

Diff 303372

llvm/test/MC/AArch64/armv8.4a-trace.s

// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.4a -o - 2>&1 %s | \ // RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.4a -o - 2>&1 %s | \
// RUN: FileCheck %s // RUN: FileCheck %s
// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+tracev8.4 -o - 2>&1 %s | \ // RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+tracev8.4 -o - 2>&1 %s | \
// RUN: FileCheck %s // RUN: FileCheck %s
// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=-v8.4a -o - %s 2>&1 | \ // RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=-v8.4a -o - %s 2>&1 | \
// RUN: FileCheck %s --check-prefix=CHECK-ERROR // RUN: FileCheck %s --check-prefix=CHECK-ERROR
// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.4a,-tracev8.4 -o - %s 2>&1 | \ // RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.4a,-tracev8.4 -o - %s 2>&1 | \
// RUN: FileCheck %s --check-prefixes NOFEATURE,CHECK-ERROR // RUN: FileCheck %s --check-prefixes CHECK-ERROR
//------------------------------------------------------------------------------ //------------------------------------------------------------------------------
// ARMV8.4-A Debug, Trace and PMU Extensions // ARMV8.4-A Debug, Trace and PMU Extensions
//------------------------------------------------------------------------------ //------------------------------------------------------------------------------
msr TRFCR_EL1, x0 msr TRFCR_EL1, x0
msr TRFCR_EL2, x0 msr TRFCR_EL2, x0
msr TRFCR_EL12, x0 msr TRFCR_EL12, x0
Show All 38 Lines