Page MenuHomePhabricator

[NFC][NewPM] Reuse PassBuilder callbacks with -O0
ClosedPublic

Authored by aeubanks on Nov 5 2020, 11:34 AM.

Details

Summary

This removes lots of duplicated code which was necessary before
https://reviews.llvm.org/D89158.
Now we can use PassBuilder::runRegisteredEPCallbacks().
This is mostly sanitizers.

There is likely more that can be done to simplify, but let's start with this.

Diff Detail

Unit TestsFailed

TimeTest
360 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

aeubanks created this revision.Nov 5 2020, 11:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2020, 11:34 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aeubanks requested review of this revision.Nov 5 2020, 11:34 AM
aeubanks updated this revision to Diff 303207.Nov 5 2020, 11:39 AM

small cleanups

aeubanks edited the summary of this revision. (Show Details)Nov 5 2020, 11:59 AM
aeubanks edited the summary of this revision. (Show Details)
aeubanks added reviewers: ychen, asbirlea, nikic.
ychen accepted this revision.Nov 12 2020, 10:54 AM

This is NFC and looks like a nice cleaup. So LGTM.

This revision is now accepted and ready to land.Nov 12 2020, 10:54 AM
This revision was landed with ongoing or failed builds.Nov 12 2020, 12:43 PM
This revision was automatically updated to reflect the committed changes.