HomePhabricator

[Sema] Special case -Werror-implicit-function-declaration and reject other…

Authored by MaskRay on Nov 5 2020, 10:25 AM.

Description

[Sema] Special case -Werror-implicit-function-declaration and reject other -Werror-

This is the only -Werror- form warning option GCC supports (gcc/c-family/c.opt).
Fortunately no other form is used anywhere.

Details

Committed
MaskRayNov 5 2020, 10:25 AM
Parents
rGf253823398dd: [clangd] Trivial: Log missing completion signals.
Branches
Unknown
Tags
Unknown

Event Timeline

dblaikie added inline comments.
/clang/test/Modules/diagnose-missing-import.m
5–7

This might not be the right place to test this flag - it's being used here, but to test another feature (modules). It might make more sense to test this more directly I guess somewhere in clang/test/Sema?

clang/test/Sema/implicit-decl.c looks suitable, perhaps?

/clang/test/Sema/vecshift.c
1–2

Did this test not need these flags? It looks like this change may've removed some intentional test coverage? (testing with -DERR not defined, specifically)