This is an archive of the discontinued LLVM Phabricator instance.

Differential D90856

[MLIR] Fix missing namespaces in `mlir/unittests/TableGen/OpBuildGen.cpp`
AbandonedPublic

Authored by frgossen on Nov 5 2020, 8:27 AM.

Details

Reviewers
pifon2a
Summary

This fixes an issue introduced in 72c65b698e3af6d1826dad43cb57d4ec06844fcc.

Diff Detail

Event Timeline

frgossen created this revision.Nov 5 2020, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2020, 8:27 AM
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 13 others. · View Herald Transcript
frgossen requested review of this revision.Nov 5 2020, 8:27 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 5 2020, 8:27 AM
pifon2a accepted this revision.Nov 5 2020, 8:32 AM
This revision is now accepted and ready to land.Nov 5 2020, 8:32 AM
Harbormaster completed remote builds in B77709: Diff 303130.Nov 5 2020, 8:35 AM
echristo added a subscriber: echristo.Nov 5 2020, 8:56 AM

For the future you can just commit this sort of thing. Though I admit to being curious about the lint error :)

frgossen abandoned this revision.Nov 5 2020, 9:16 AM

https://reviews.llvm.org/D90858

Revision Contents

PathSize
mlir/
unittests/
TableGen/
2 lines

Diff 303130

mlir/unittests/TableGen/OpBuildGen.cpp

Show All 13 Lines
#include "mlir/IR/Attributes.h" #include "mlir/IR/Attributes.h"
#include "mlir/IR/Builders.h" #include "mlir/IR/Builders.h"
#include "mlir/IR/Dialect.h" #include "mlir/IR/Dialect.h"
#include "mlir/IR/Identifier.h" #include "mlir/IR/Identifier.h"
#include "mlir/IR/StandardTypes.h" #include "mlir/IR/StandardTypes.h"
#include "gmock/gmock.h" #include "gmock/gmock.h"
#include <vector> #include <vector>
using namespace mlir::test;
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: expected namespace name [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: expected namespace name [clang-diagnostic-error] [[https://github.
namespace mlir { namespace mlir {
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Test Fixture // Test Fixture
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
static MLIRContext &getContext() { static MLIRContext &getContext() {
static MLIRContext ctx; static MLIRContext ctx;
▲ Show 20 Lines • Show All 192 Lines • Show Last 20 Lines