This doesn't add functionality, but just adds the new types and renames the master callback to masked callback.
Details
Diff Detail
Unit Tests
Event Timeline
LGTM, one nit below.
openmp/runtime/test/ompt/synchronization/taskgroup.c | ||
---|---|---|
32 ↗ | (On Diff #302798) | No replacement? |
openmp/runtime/test/ompt/synchronization/taskgroup.c | ||
---|---|---|
32 ↗ | (On Diff #302798) | The test does not use the callback, so I removed the check rather than replacing it. |
The ompt_callback_master_t type is deprecated, but not removed. So, omp-tools.h still needs to define the type.
I moved the existing master.c test to masked.c and added a new master.c test, which just tries to register the deprecated callback.
I also ran all tests with cmake -DOPENMP_TEST_FLAGS:STRING="-Werror -Wno-#warnings" and fixed all warnings for the ompt test cases (mainly about missing cases in switch statements).
Are all uses of on_ompt_callback_master expected to be replaced?
I see this is still using it:
https://github.com/llvm/llvm-project/blob/master/openmp/tools/multiplex/tests/custom_data_storage/first-tool.h#L126