This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Restructure C API tests for IR
ClosedPublic

Authored by ftynse on Nov 4 2020, 1:30 AM.

Details

Summary

The test file is a long list of functions, followed by equally long FileCheck
comments inside "main". Distribute FileCheck comments closer to the functions
that produce the output we are checking.

Diff Detail

Event Timeline

ftynse created this revision.Nov 4 2020, 1:30 AM
ftynse requested review of this revision.Nov 4 2020, 1:30 AM
stellaraccident accepted this revision.Nov 4 2020, 11:13 AM

Thanks, looks good. This had been annoying me but never quite enough to fix it.

This revision is now accepted and ready to land.Nov 4 2020, 11:13 AM
mehdi_amini accepted this revision.Nov 4 2020, 11:34 AM

Thanks! That's also how I intuitively wrote the CHECKs for the pass manager tests.

This revision was automatically updated to reflect the committed changes.