This is an archive of the discontinued LLVM Phabricator instance.

Differential D90740

Fix linkage error on mlirLogicalResultIsFailure.
ClosedPublic

Authored by stellaraccident on Nov 3 2020, 10:47 PM.

Details

Reviewers
mehdi_amini
Commits
rGebe12df89652: Fix linkage error on mlirLogicalResultIsFailure.
Summary
  • For C, this needs to be inline static like the others.

Diff Detail

Event Timeline

stellaraccident created this revision.Nov 3 2020, 10:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2020, 10:47 PM
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 13 others. · View Herald Transcript
stellaraccident requested review of this revision.Nov 3 2020, 10:47 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 3 2020, 10:47 PM
stellaraccident added a reviewer: mehdi_amini.Nov 3 2020, 10:47 PM

Submitting to unbreak the build.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2020, 10:48 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGebe12df89652: Fix linkage error on mlirLogicalResultIsFailure. (authored by stellaraccident). · Explain Why
This revision was automatically updated to reflect the committed changes.
stellaraccident added a commit: rGebe12df89652: Fix linkage error on mlirLogicalResultIsFailure..
Harbormaster completed remote builds in B77510: Diff 302755.Nov 3 2020, 11:16 PM

Revision Contents

PathSize
mlir/
include/
mlir-c/
4 lines

Diff 302755

mlir/include/mlir-c/Support.h

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
* Instances of MlirLogicalResult must only be inspected using the associated * Instances of MlirLogicalResult must only be inspected using the associated
* functions. */ * functions. */
struct MlirLogicalResult { struct MlirLogicalResult {
int8_t value; int8_t value;
}; };
typedef struct MlirLogicalResult MlirLogicalResult; typedef struct MlirLogicalResult MlirLogicalResult;
/** Checks if the given logical result represents a success. */ /** Checks if the given logical result represents a success. */
inline int mlirLogicalResultIsSuccess(MlirLogicalResult res) { inline static int mlirLogicalResultIsSuccess(MlirLogicalResult res) {
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: unused function 'mlirLogicalResultIsSuccess' [clang-diagnostic-unused-function]
not useful

Lint: Pre-merge checks: clang-tidy: warning: unused function 'mlirLogicalResultIsSuccess' [clang-diagnostic-unused…
return res.value != 0; return res.value != 0;
} }
/** Checks if the given logical result represents a failure. */ /** Checks if the given logical result represents a failure. */
inline int mlirLogicalResultIsFailure(MlirLogicalResult res) { inline static int mlirLogicalResultIsFailure(MlirLogicalResult res) {
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: unused function 'mlirLogicalResultIsFailure' [clang-diagnostic-unused-function]
not useful

Lint: Pre-merge checks: clang-tidy: warning: unused function 'mlirLogicalResultIsFailure' [clang-diagnostic-unused…
return res.value == 0; return res.value == 0;
} }
/** Creates a logical result representing a success. */ /** Creates a logical result representing a success. */
inline static MlirLogicalResult mlirLogicalResultSuccess() { inline static MlirLogicalResult mlirLogicalResultSuccess() {
MlirLogicalResult res = {1}; MlirLogicalResult res = {1};
return res; return res;
} }
Show All 12 Lines