This is an archive of the discontinued LLVM Phabricator instance.

Move MlirStringCallback declaration from mlir-c/IR.h to mlir-c/Support.h (NFC)
ClosedPublic

Authored by mehdi_amini on Nov 3 2020, 10:29 PM.

Details

Summary

This is a generic utility that can be reused beyond the IR bindings.

Diff Detail

Event Timeline

mehdi_amini created this revision.Nov 3 2020, 10:29 PM
mehdi_amini requested review of this revision.Nov 3 2020, 10:29 PM
stellaraccident accepted this revision.Nov 3 2020, 10:52 PM
This revision is now accepted and ready to land.Nov 3 2020, 10:52 PM
ftynse accepted this revision.Nov 4 2020, 12:59 AM
ftynse added inline comments.
mlir/include/mlir-c/Support.h
53

Nit: reformat comment to C99

mehdi_amini added inline comments.Nov 4 2020, 10:30 AM
mlir/include/mlir-c/Support.h
53

I plan to do it separately for all the APIs in these headers.

This revision was landed with ongoing or failed builds.Nov 4 2020, 10:46 AM
This revision was automatically updated to reflect the committed changes.