This is an archive of the discontinued LLVM Phabricator instance.

Differential D90696

[flang] Dodge gcc 8.2.0 build problem (NFC)
ClosedPublic

Authored by klausler on Nov 3 2020, 10:49 AM.

Details

Reviewers
sscalpone
jeanPerier
PeteSteinfeld
Commits
rG7ba393efe5fe: [flang] Dodge gcc 8.2.0 build problem (NFC)
Summary

Add explicit member initializers to the declarations of
some constexpr values added in a recent patch to avoid an
apparent problem with gcc 8.2.0 with default initializers.

Diff Detail

Event Timeline

klausler created this revision.Nov 3 2020, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2020, 10:49 AM
Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript
klausler requested review of this revision.Nov 3 2020, 10:49 AM
Harbormaster completed remote builds in B77429: Diff 302625.Nov 3 2020, 11:16 AM
PeteSteinfeld accepted this revision.Nov 3 2020, 12:04 PM

All of the flang front end builds without warnings, and everything tests cleanly.

This revision is now accepted and ready to land.Nov 3 2020, 12:04 PM
Closed by commit rG7ba393efe5fe: [flang] Dodge gcc 8.2.0 build problem (NFC) (authored by klausler). · Explain WhyNov 3 2020, 4:31 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG7ba393efe5fe: [flang] Dodge gcc 8.2.0 build problem (NFC).

Revision Contents

PathSize
flang/
lib/
Evaluate/
24 lines

Diff 302625

flang/lib/Evaluate/intrinsics.cpp

Context not available.
// KIND(0), KIND(0.0), KIND(''), &c. value for the function result. // KIND(0), KIND(0.0), KIND(''), &c. value for the function result.
static constexpr IntrinsicDummyArgument DefaultingKIND{"kind", static constexpr IntrinsicDummyArgument DefaultingKIND{"kind",
{IntType, KindCode::kindArg}, Rank::scalar, {IntType, KindCode::kindArg}, Rank::scalar,
Optionality::defaultsToDefaultForResult}; Optionality::defaultsToDefaultForResult, common::Intent::In};
// MatchingDefaultKIND is a KIND= argument whose default value is the // MatchingDefaultKIND is a KIND= argument whose default value is the
// kind of any "Same" function argument (viz., the one whose kind pattern is // kind of any "Same" function argument (viz., the one whose kind pattern is
// "same"). // "same").
static constexpr IntrinsicDummyArgument MatchingDefaultKIND{"kind", static constexpr IntrinsicDummyArgument MatchingDefaultKIND{"kind",
{IntType, KindCode::kindArg}, Rank::scalar, {IntType, KindCode::kindArg}, Rank::scalar, Optionality::defaultsToSameKind,
Optionality::defaultsToSameKind}; common::Intent::In};
// SizeDefaultKind is a KIND= argument whose default value should be // SizeDefaultKind is a KIND= argument whose default value should be
// the kind of INTEGER used for address calculations, and can be // the kind of INTEGER used for address calculations, and can be
// set so with a compiler flag; but the standard mandates the // set so with a compiler flag; but the standard mandates the
// kind of default INTEGER. // kind of default INTEGER.
static constexpr IntrinsicDummyArgument SizeDefaultKIND{"kind", static constexpr IntrinsicDummyArgument SizeDefaultKIND{"kind",
{IntType, KindCode::kindArg}, Rank::scalar, {IntType, KindCode::kindArg}, Rank::scalar, Optionality::defaultsToSizeKind,
Optionality::defaultsToSizeKind}; common::Intent::In};
static constexpr IntrinsicDummyArgument RequiredDIM{ static constexpr IntrinsicDummyArgument RequiredDIM{"dim",
"dim", {IntType, KindCode::dimArg}, Rank::scalar, Optionality::required}; {IntType, KindCode::dimArg}, Rank::scalar, Optionality::required,
static constexpr IntrinsicDummyArgument OptionalDIM{ common::Intent::In};
"dim", {IntType, KindCode::dimArg}, Rank::scalar, Optionality::optional}; static constexpr IntrinsicDummyArgument OptionalDIM{"dim",
static constexpr IntrinsicDummyArgument OptionalMASK{ {IntType, KindCode::dimArg}, Rank::scalar, Optionality::optional,
"mask", AnyLogical, Rank::conformable, Optionality::optional}; common::Intent::In};
static constexpr IntrinsicDummyArgument OptionalMASK{"mask", AnyLogical,
Rank::conformable, Optionality::optional, common::Intent::In};
struct IntrinsicInterface { struct IntrinsicInterface {
static constexpr int maxArguments{7}; // if not a MAX/MIN(...) static constexpr int maxArguments{7}; // if not a MAX/MIN(...)
Context not available.