This is an archive of the discontinued LLVM Phabricator instance.

Remove mlir-c/Core.h which is superseded by the new API in mlir-c/IR.h
ClosedPublic

Authored by mehdi_amini on Nov 2 2020, 1:29 PM.

Details

Summary

This header was an initial early attempt at a crude C API for bindings,
but it isn't used and redundant with the new API. At this point it
only contributes to more confusion.

Most importantly: the implementation for the APIs defined in this
header are not in the repo!

Diff Detail

Event Timeline

mehdi_amini created this revision.Nov 2 2020, 1:29 PM
mehdi_amini requested review of this revision.Nov 2 2020, 1:29 PM
stellaraccident accepted this revision.Nov 2 2020, 3:53 PM

Sgtm, but I lack knowledge about any existing users, which Alex tracks. Not sure if he had some reason for wanting it around for the time being.

This revision is now accepted and ready to land.Nov 2 2020, 3:53 PM
mehdi_amini edited the summary of this revision. (Show Details)Nov 2 2020, 5:11 PM
This revision was landed with ongoing or failed builds.Nov 3 2020, 3:15 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a comment.Nov 3 2020, 4:18 AM

I think existing users have a local copy of this file together with the underlying implementation.